fix: logging issues #593
Merged
fix: logging issues #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #592 This is a minor regression in unreleased code, so not bothering with a changelog entry. Also added consistent checking of %gitSCOutputFlag - we've been getting some duplicated logs in Pull because of this
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #593 +/- ##
==========================================
- Coverage 26.17% 26.14% -0.03%
==========================================
Files 21 21
Lines 2808 2811 +3
==========================================
Hits 735 735
- Misses 2073 2076 +3 ☔ View full report in Codecov by Sentry. |
isc-etamarch
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #592
This is a minor regression in unreleased code, so not bothering with a changelog entry. Also added consistent checking of %gitSCOutputFlag - we've been getting some duplicated logs in Pull because of this