Skip to content

Initialize uses entered repo #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 24, 2024
Merged

Initialize uses entered repo #571

merged 4 commits into from
Oct 24, 2024

Conversation

isc-etamarch
Copy link
Collaborator

Fixes #486

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.94%. Comparing base (3e8a0f4) to head (bf9f5db).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #571   +/-   ##
=======================================
  Coverage   25.94%   25.94%           
=======================================
  Files          18       18           
  Lines        2713     2713           
=======================================
  Hits          704      704           
  Misses       2009     2009           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@isc-tleavitt isc-tleavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a really dumb nitpick here, sorry

@isc-etamarch
Copy link
Collaborator Author

isc-etamarch commented Oct 23, 2024

Weird, had to delete and re-type the tabs since they looked fine in my editor lol

Copy link
Collaborator

@isc-tleavitt isc-tleavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more point I missed the first time around.

@isc-tleavitt isc-tleavitt merged commit 9d281f3 into main Oct 24, 2024
2 checks passed
@isc-tleavitt isc-tleavitt deleted the issue-486 branch October 24, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings page "initialize" uses currently stored rather than entered-in-form repo root
3 participants