Skip to content

Add remote repository to settings #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 9, 2024
Merged

Add remote repository to settings #529

merged 5 commits into from
Oct 9, 2024

Conversation

isc-etamarch
Copy link
Collaborator

@isc-etamarch isc-etamarch commented Oct 8, 2024

Fixes #448
Fixes #375

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 25.46%. Comparing base (92c80cb) to head (a75d871).

Files with missing lines Patch % Lines
cls/SourceControl/Git/Utils.cls 0.00% 11 Missing ⚠️
cls/SourceControl/Git/WebUIDriver.cls 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #529      +/-   ##
==========================================
- Coverage   25.60%   25.46%   -0.14%     
==========================================
  Files          18       18              
  Lines        2582     2596      +14     
==========================================
  Hits          661      661              
- Misses       1921     1935      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@isc-tleavitt isc-tleavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a CHANGELOG.md entry

Added changelog entry
Check censored remote against censored remote to see if the settings entry has been changed
Copy link
Collaborator

@isc-tleavitt isc-tleavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry... one more thing I think would be good to change. Otherwise good to go.

@isc-tleavitt isc-tleavitt merged commit b8bc46d into main Oct 9, 2024
2 checks passed
@isc-tleavitt isc-tleavitt deleted the issue-448 branch October 9, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show (and allow changing) configured remote in settings page Show configured remotes in Settings, WebUI?
3 participants