Fix hl7 extensions inconsistencies #508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #508 +/- ##
==========================================
+ Coverage 25.06% 25.51% +0.44%
==========================================
Files 18 18
Lines 2541 2559 +18
==========================================
+ Hits 637 653 +16
- Misses 1904 1906 +2 ☔ View full report in Codecov by Sentry. |
Stole this from IPM Some more work needed still
This code does not actually fix the issue
Also skip the directory scan because it'd be slow and is generally unnecessary.
isc-tleavitt
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Reviewed this with @isc-etamarch in a few calls today. There are a few other things we'll want to do but this is good for purposes of the current issue/PR.
@isc-pbarton I'd appreciate if you could review too since I made a few of the changes here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #495