Skip to content

fix: menu item names in VSCode/SMP #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Added a new "Branch" parameter to `##class(SourceControl.Git.PullEventHandler)` (#351)
- Command-line utility to do a baseline export of items in a namespace

### Fixed
- Menu items names are properly translated from internal name in VSCode, Management Portal (#372)

## [2.3.1] - 2024-04-30

Expand Down
7 changes: 6 additions & 1 deletion cls/SourceControl/Git/Extension.cls
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,6 @@ Method LocalizeName(name As %String) As %String

Method OnSourceMenuItem(name As %String, ByRef Enabled As %String, ByRef DisplayName As %String, InternalName As %String) As %Status
{

if name = "Settings" {
set Enabled = 1
quit $$$OK
Expand Down Expand Up @@ -159,6 +158,9 @@ Method OnSourceMenuItem(name As %String, ByRef Enabled As %String, ByRef Display
} else {
set Enabled = -1
}
if (name '= "") {
set DisplayName = ..LocalizeName(name)
}
quit $$$OK
}

Expand Down Expand Up @@ -187,6 +189,9 @@ Method OnSourceMenuContextItem(itemName As %String, menuItemName As %String, ByR
} else {
set Enabled = $case(menuItemName, "AddToSC":1,:-1)
}
if (menuItemName '= "") {
set DisplayName = ..LocalizeName(menuItemName)
}
quit $$$OK
}

Expand Down
Loading