Skip to content

No more sclist #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 16, 2022
Merged

No more sclist #125

merged 10 commits into from
Feb 16, 2022

Conversation

isc-svelury
Copy link
Contributor

  1. Remove all references to sc-list from codebase.
  2. Remove workaround for .pkg not being added in VS Code. This was addressed here: Append .pkg to package name when passed to source control / server command extensions intersystems-community/vscode-objectscript#776
  3. Add and Remove are now both displayed when the user selects the Server Source Control Menu for a package.
  4. We are no longer concerned with checking if a package should be added to source control (if all its files are in source control) and removing a packaging from source control (if even one of its files is no longer in source control). Packages are never directly added to source control, only their files are.
  5. Created 2 new methods to add and remove files from server side source control only. These are used after git pull, before calling the pull event handler.
  6. Removed special handling for deleted files from the IncrementalLoad event handler.

Closes #120

@isc-svelury isc-svelury added the enhancement New feature or request label Feb 16, 2022
@isc-tleavitt
Copy link
Collaborator

This looks good and relatively straightforward to me from a code standpoint. I'm going to squash and merge, but will want to do some testing around this specifically before our next release. (But I'll be testing everything, not just this, so makes sense to merge in the meanwhile.)

@isc-tleavitt isc-tleavitt merged commit 5cc6683 into main Feb 16, 2022
@isc-tleavitt isc-tleavitt deleted the no-more-sclist branch February 16, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Track resources in the repo via global rather than sc-list.txt
2 participants