Skip to content

Configuration fails if git is not on path #632

Closed
@isc-tleavitt

Description

@isc-tleavitt

Error log:

NAMESPACE>do ##class(SourceControl.Git.API).Configure()
Configured SourceControl.Git.Extension as source control class for namespace CPM
Configured default mappings for classes, routines, and include files. You can cu
stomize these in the global:
     ^SYS("SourceControl","Git","settings","mappings")
WARNING: You are using an older version of git which is not compatible with git-
source-control. Please upgrade to git version 2.31.0 or greater to continue
Cancelling git-source-control configuration...

Intuitively I think the issue is:

        set gitExists = ##class(SourceControl.Git.Utils).GitBinExists(.version) // version is "", gitExists = 0
        set gitBinPath = ##class(SourceControl.Git.Utils).GitBinPath(.isDefault)

        // Make sure they are using an appropriate git version
        if (+$PIECE(version,"version ",2))<2.31 { //0 < 2.31
            write !!, "WARNING: You are using an older version of git which is not compatible with git-source-control. Please upgrade to git version 2.31.0 or greater to continue"
            write !!, "Cancelling git-source-control configuration..."
            quit
        }

We shouldn't do the version check if gitExists is false.

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingcustomerBased on customer feedback (as opposed to something identified by developers)

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions