Skip to content

Git diff-based loading should do the right thing with detected renames #389

Closed
@isc-tleavitt

Description

@isc-tleavitt

Git diff might detect renames. These look like (e.g., from https://stackoverflow.com/questions/40702017/what-does-the-number-in-rnumber-after-a-git-rename-mean):

R079 Web/Views/Shared/Blocks/ChristmasLotteryBlock.cshtml Web/Views/Shared/Blocks/ChristmasLotteryBlock/Index.cshtml
R076 Web/Static/blocks/_block_christmas-lottery-intro.html Web/Views/Shared/Blocks/ChristmasLotteryBlock/_intro.cshtml
R099 Web/Static/blocks/_block_christmas-lottery-popup.html Web/Views/Shared/Blocks/ChristmasLotteryBlock/_popup.cshtml
M Web/Web.csproj

For purposes of IRIS, the file on the left is a delete and the file on the right is an add. Right now our diff-based incremental load tries to act on the file on the left, which doesn't exist, which can lead to very odd inexplicable failures after e.g. changing branches from the WebUI.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions