fix(config): startup config threading, container exposure, HOME watch root, fast probe, CLI web_prefix (fixes #21) - #28
Merged
Conversation
PYDuquesnoy
force-pushed
the
fix/security-deps
branch
from
August 7, 2026 13:35
a883e0f to
e71288a
Compare
…OME watch root, fast probe, CLI web_prefix, port alias, quiet retries (fixes #21) Seven connection/config fixes from the upstream audit, all hitting launcher-spawned MCP servers (Claude Desktop/Code start us with cwd=/) or webgateway-prefixed setups — i.e. our workshop deployments: - config hot-reload watched /.iris-agentic-dev.toml when spawned with CWD=/ — the watcher silently never fired. Fall back to $HOME (upstream 0c922ec). - the loaded config path never reached ConnectionState at startup: check_config reported connection_source=auto_discovered/config_file=null until the first hot-reload. apply_workspace_config_with_path threads it through with_registry_and_toolset (upstream 4daefc5 / #82). - check_config reported container:null when the toml set host+container — the connection got DiscoverySource::EnvVar. Now Docker{container_name} (upstream 1bcd0a9 / #89). - fallback_warning in check_config when connected via discovery with no config file — silent wrong-instance targeting (upstream a7ca7c8 / #82). - startup probe used the 30s general client; a down IRIS stalled startup. probe_client(): 5s connect / 10s total (upstream b3f3cf1 / #85). - compile CLI hardcoded http://host:port — unusable behind a webgateway prefix. --web-prefix/--scheme args (env IRIS_WEB_PREFIX/IRIS_SCHEME), base_url built like the mcp path (upstream b3f3cf1). - toml accepts port as alias for web_port (upstream da63abb); cold-start retry noise demoted WARN→debug with info-on-recovery (upstream 259bd1d). Verified live against dev IRIS: toml with host+container now yields check_config {container: "iris-dev-environment", config_file: <path>, connection_source: "config_file", fallback_warning: null} — all three previously-broken fields in one probe. New unit tests for path threading, Docker source, and the port alias. CI suites 9/9, e2e 10/10, clippy clean. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
PYDuquesnoy
force-pushed
the
fix/connection-config-batch
branch
from
August 7, 2026 13:35
28d859e to
589c9ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21 — the seven verified connection/config defects from the upstream audit (
0c922ec,4daefc5/#82,1bcd0a9/#89,a7ca7c8,b3f3cf1/#85,da63abb,259bd1d). Full breakdown in the commit message.Live verification against the dev IRIS: a toml with
host+containernow producescheck_config → {container: "iris-dev-environment", config_file: <path>, connection_source: "config_file"}— all three fields were previously null/wrong at startup.compile --helpshows the new--web-prefix/--schemeargs.New unit tests: config-path threading (explicit vs loaded),
DiscoverySource::Dockerexposure,portalias. CI suites 9/9, e2e 10/10, clippy clean.Stacked on #27 (→ #26 → #25 → #16 → master).
🤖 Generated with Claude Code