Skip to content

Try to end /api/atelier web sessions when extension deactivates #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gjsjohnmurray
Copy link
Collaborator

This PR makes the extension try to end its /api/atelier web sessions when deactivating (e.g. exiting VS Code or running Developer: Reload Window)

Copy link
Collaborator Author

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will now investigate making a similar change in the ObjectScript extension.

@isc-bsaviano
Copy link
Collaborator

isc-bsaviano commented Apr 28, 2025

@gjsjohnmurray I already have that code ready, I just didn't open the PR yet! I have it ready for the Language Server as well. I'm just waiting on Raj's approval.

@gjsjohnmurray gjsjohnmurray merged commit aa0d8bc into intersystems-community:master Apr 30, 2025
3 checks passed
@gjsjohnmurray gjsjohnmurray deleted the violet-stork branch April 30, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants