Repository navigation
fix(publishing): set or clear one content list description (#5249) - #5259
Merged
natechadwick-intsof merged 3 commits intoOct 5, 2026
Merged
Conversation
Description-only updateContentList leaves the name, type, generator or legacy URL, and item filter stored. A blank description clears it. Text longer than 255 characters is HTTP 400 and does not write. Parent: #4531 > Co-Authored by Grok Build 1.0.46 using grok-4.6 with agent night-issue-prs.
> Co-Authored by Grok Build 1.0.46 using grok-4.6 with agent night-issue-prs.
Independent mkd-code-review of the PR head: 0 in-diff bugs. Recommendation approve. Ollama CUDA OOM is not a product defect. > Co-Authored by Grok Build 1.0.46 using grok-4.6 with agent night-issue-prs-erlang.
Collaborator
Author
|
LGTM. Independent Erlang review (mkd-code-review 0.1.18, pack percussion, gate advisory, base origin/main). Persona: erlang 0.1.1. Persona source: ~/.local/share/mkd/agents/erlang. In-diff bugs: 0. Recommendation: approve. Same-login APPROVE is not available; squash-merge follows. Preexisting rows do not block. Ollama dev-coder CUDA OOM is not a product defect.
|
natechadwick-intsof
deleted the
fix/issue-5249-content-list-description
branch
October 5, 2026 23:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Publishing Design can set or clear one content list description without changing the name, type, generator or legacy URL, or item filter. Parent #4531 slice 83. Fixes #5249.
Save sends a description-only body on the existing content-list PUT (
PUT /services/sitemanage/publishingdesign/contentlists/{id}). A non-null description is trimmed; a blank value clears the stored description. Descriptions longer than 255 characters (RXCONTENTLIST.DESCRIPTION) are rejected with HTTP 400 before any field is written. HTTP 403 and a conflicting rename (409) also leave the previous description. Cancel does not call the server.Operator: Grok: night-issue-prs (model grok-4.6)
Test plan
description.Checklist
product-docs/8.2/admin/publishing.md(Set a content list description)PSPublishingDesignRestServiceTestdescription-only / blank-clear / 400 / 403 / 409; VitestcontentListDescription.test.ts(7) andDesignSection.contentListDescription.test.tsx(9)modules/perc-qa-automation/frontend/tests/publishing/designContentListDescription.spec.js(3 passed on H2)projects/sitemanageandWebUI. Nofinal/ signature change, so no reverse-dep install.Build evidence
modules_built:
projects/sitemanage,WebUIdownstream_checked: none (no type made final or sealed; no public or protected signature change)
Preexisting javadoc, dependency-plugin, vite chunk-size, and npm EBADENGINE warnings were already on the branch baseline. None are in the new content-list description code.
UI proof (H2 QA)
console-clean=yes (spec asserts no pageerror / console error on the exercised paths).
server.log-clean=yes (no ERROR, FATAL, or SEVERE lines in
/opt/Percussion/jetty/base/logs/server.logfor this boot, including the Playwright window).Pre-push local code review
Erlang review — PR #5259
Scope
CLI stdout (
mkd-code-review analyze --format markdown)Summary
Machine analysis found 1 finding(s), 0 bug(s).
Scope
Recommendation
approve
Gate
Issues
Issue 1 -- Severity: suggestion
File: review
Rule:
llm.errorTool:
llmDescription: model
ollama-dev-coderfailed: http: status 500 Internal Server Error body {"error":{"message":"llama-server process has terminated: exit status 1: cudaMalloc failed: out of memory\nalloc_tensor_range: failed to allocate CUDA0 buffer of size 5064192000\nerror loading model: unable to allocate CUDA0 buffer","type":"api_error","param":null,"code":null}}Status: open