Repository navigation
fix: set the item filter on a content list - #5174
Merged
natechadwick-intsof merged 4 commits intoOct 4, 2026
Merged
Conversation
Publishing Design accepts itemFilterId on a modern content list (uuid or name), clears the stored filter when the value is blank, and leaves it unchanged when the field is omitted. The editor keeps the previous filter until save succeeds. Fixes #5160 > Co-Authored by Grok Build 1.0.46 using grok-4.7 with agent night-issue-prs.
Bare item-filter uuids collide across hosts, so Design was saving an id the server could not resolve. The editor now sends the filter name and reloads the select from the stored name. Fixes #5160 > Co-Authored by Grok Build 1.0.46 using grok-4.7 with agent night-issue-prs.
> Co-Authored by Grok Build 1.0.46 using grok-4.7 with agent night-issue-prs.
Independent advisory review of 8ff2b38. Machine gate is clean. Ollama CUDA OOM is a non-blocking suggestion. > Co-Authored by Grok Build 1.0.46 using grok-4.7 with agent night-issue-prs-erlang.
Collaborator
Author
|
LGTM. Independent Erlang review: machine gate clean (0 bugs). Ollama
|
natechadwick-intsof
deleted the
fix/issue-5160-content-list-item-filter
branch
October 4, 2026 16:45
This was referenced Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Publishing Design can set or clear the item filter on one modern content list. The editor saves the filter name (item-filter uuids are not unique across hosts). A blank
itemFilterIdclears the stored filter. Omitting the field leaves it unchanged. An unknown filter is HTTP 400Unknown item filterand is rejected before create or save. The saved filter is shown only after the list reloads. Cancel and a blank name do not call the server. HTTP 400, 403, and 409 stay in the editor.Parent: #4531. Fixes #5160.
Operator: Grok: night-issue-prs (model grok-4.7)
Test plan
Checklist
product-docs/8.2/admin/publishing.md(Set the item filter on a content list)modules/perc-qa-automation/frontend/tests/publishing/designContentListItemFilter.spec.js(2 passed on H2)Build evidence
rtk mvncould not spawn (Permission denied). Builds usedJAVA_HOME=/usr/lib/jvm/java-21-openjdkand the repo-rootbash mvnw(Maven 3.9.11).modules_built: projects/sitemanage,WebUI,modules/perc-qa-automation
cd rest && bash ../mvnw clean install— classpath alignment only (this branch's rest vs a newer installed snapshot). BUILD SUCCESS. Tests run: 1660, Failures: 0. No rest product change in this PR.cd projects/sitemanage && bash ../../mvnw clean install— BUILD SUCCESS. Surefire TEST-*.xml: Tests run: 3457, Failures: 0, Errors: 0, Skipped: 125.cd WebUI && bash ../mvnw clean install— BUILD SUCCESS. Vitest Test Files 658 passed, Tests 5973 passed. Java Tests run: 69, Failures: 0.cd modules/perc-qa-automation && bash ../../mvnw clean install— BUILD SUCCESS. No tests to run (Playwright is not bound to default Surefire).downstream_checked: none (no
final/sealedtype and no public method or constructor signature change; noextends PSContentListSummary).UI proof (C5)
python3 docker/scripts/perc-devctl.py qa-up— containerperc-matrix-cms-h2, TEST_CMS_URL=http://127.0.0.1:9993 (ADMIN_PASSWORD from qa-up stdout, not recorded here).python3 docker/scripts/perc-devctl.py qa-deploy-webuiRESULT:OK, thenqa-healthRESULT:OK HTTP:200 HEALTH:healthy.cd modules/perc-qa-automation/frontend && rtk npm run test:surface -- --path tests/publishing/designContentListItemFilter.spec.jswith TEST_CMS_URL, ADMIN_USERNAME=Admin, TEST_DB_TYPE=h2, TEST_PRODUCT=cms. 2 passed./opt/Percussion/jetty/base/logs/server.logduring the passing run).Pre-push local code review
Summary
Machine analysis found 1 finding(s), 0 bug(s).
Scope
Recommendation
approve
Gate
Issues
Issue 1 -- Severity: suggestion
File: review
Rule:
llm.errorTool:
llmDescription: model
ollama-dev-coderfailed: http: status 500 Internal Server Error body {"error":{"message":"llama-server process has terminated: exit status 1: cudaMalloc failed: out of memory\nalloc_tensor_range: failed to allocate CUDA0 buffer of size 5064192000\nerror loading model: unable to allocate CUDA0 buffer","type":"api_error","param":null,"code":null}}Status: open
Erlang judgment: approve. Zero machine bugs on 17 files. Unknown filters are rejected before save; the editor sends the filter name and omits the field until the catalog loads. Ollama
dev-coderHTTP 500 (CUDA out of memory) is a non-blocking suggestion. Report:docs/ai-generated/code-reviews/pr-5174-erlang.md(commitb468a18a82fd).