Repository navigation
feat(publish): set the open site default workflow - #5074
Merged
Merged
Conversation
PublishingShell chooses a catalog workflow and saves it with PUT /services/sites. Cancel, an empty choice, and HTTP 400/403/409 do not claim success. Fixes #5061 > Co-Authored by Grok Build 1.0.46 using grok-4.6 with agent night-issue-prs.
…kflow H2 sample sites already use the only stock workflow. The surface spec creates a catalog workflow first so save, refresh, cancel, empty, and 409 are observable. > Co-Authored by Grok Build 1.0.46 using grok-4.6 with agent night-issue-prs.
> Co-Authored by Grok Build 1.0.46 using grok-4.6 with agent night-issue-prs-erlang.
Collaborator
Author
|
Erlang 0.1.1 LGTM (same-login APPROVE rejected). 0 blocking bugs. Not merged: required checks still running after the review-report commit.
|
Collaborator
Author
|
LGTM. Same-login APPROVE is rejected by GitHub. Re-ran mkd-code-review 0.1.18 on head 15b26fe against origin/main (Persona: erlang 0.1.1, Persona source: ~/.local/share/mkd/agents/erlang). In-diff findings: 0 bugs. Recommendation: approve. Required checks on this snapshot are SUCCESS or skipped/neutral. Squash-merging.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Publishing shell: choose the open site's default workflow from the workflow catalog and save it with
PUT /services/sites/{nameOrId}(workflowNameonly). The workspace shows the saved name after success and after leaving and reopening the site. Cancel, an unchanged name, and an empty choice do not call the server and do not show a saved notice. A name that is not in the catalog is not sent. HTTP 400, 403, and 409 stay on the form.Part of #4531. Fixes #5061.
Operator: Grok: night-issue-prs (model grok-4.6)
Test plan
mvn clean install(Java tests + full Vitest)tests/publishing/siteDefaultWorkflow.spec.js)Product documentation
product-docs/8.2/admin/publishing.md(Set the open site default workflow)Build evidence
WebUIworkflowNamecontract)cd WebUI && rtk mvn clean install— BUILD SUCCESS. JavaTests run: 69, Failures: 0, Errors: 0, Skipped: 0. VitestTest Files 604 passed,Tests 5537 passed.SiteDefaultWorkflowPanel.test.tsxandsiteDefaultWorkflow.test.ts— 8 passed.UI proof (C5)
python3 docker/scripts/perc-devctl.py qa-up—TEST_CMS_URL=http://127.0.0.1:9993, containerperc-matrix-cms-h2,RESULT:OKqa-healthhealthy HTTP 200qa-deploy-webui(modern SPA from this worktree) thenqa-healthagainworkflowNameon site GET/PUT.qa-deploy-war-jars --restart-jettycopied the worktreeperc-system,rest, andsitemanageSNAPSHOT jars into the Rhythmyx WAR and restarted Jetty in-cell (notdocker restart).qa-healthhealthy again. PUT then returnedworkflowName.cd modules/perc-qa-automation/frontend && rtk npm run test:surface -- --path tests/publishing/siteDefaultWorkflow.spec.jswithTEST_CMS_URL,ADMIN_USERNAME=Admin,TEST_DB_TYPE=h2,TEST_PRODUCT=cms— 1 passed/opt/Percussion/jetty/base/logs/server.logafter the run)Pre-push local code review
Summary
Machine analysis found 0 finding(s), 0 bug(s).
Scope
Recommendation
approve
Gate
Issues
No issues.