Skip to content

feat(publish): set the open site default workflow - #5074

Merged
natechadwick-intsof merged 3 commits into
mainfrom
fix/issue-5061-site-default-workflow
Oct 2, 2026
Merged

natechadwick-intsof merged 3 commits into
mainfrom
fix/issue-5061-site-default-workflow

Conversation

@natechadwick-intsof

@natechadwick-intsof natechadwick-intsof commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Publishing shell: choose the open site's default workflow from the workflow catalog and save it with PUT /services/sites/{nameOrId} (workflowName only). The workspace shows the saved name after success and after leaving and reopening the site. Cancel, an unchanged name, and an empty choice do not call the server and do not show a saved notice. A name that is not in the catalog is not sent. HTTP 400, 403, and 409 stay on the form.

Part of #4531. Fixes #5061.

Operator: Grok: night-issue-prs (model grok-4.6)

Test plan

  • Vitest: catalog resolve, unchanged name, empty choice, HTTP 400/403/409
  • WebUI mvn clean install (Java tests + full Vitest)
  • Surface Playwright on H2 QA (tests/publishing/siteDefaultWorkflow.spec.js)
  • Human: open Publish, edit default workflow, confirm the name survives a browser refresh

Product documentation

  • Updated product-docs/8.2/admin/publishing.md (Set the open site default workflow)

Build evidence

  • modules_built: WebUI
  • downstream_checked: none (no Java type or signature change; existing site PUT workflowName contract)
  • cd WebUI && rtk mvn clean install — BUILD SUCCESS. Java Tests run: 69, Failures: 0, Errors: 0, Skipped: 0. Vitest Test Files 604 passed, Tests 5537 passed.
  • Focused Vitest before the module install: SiteDefaultWorkflowPanel.test.tsx and siteDefaultWorkflow.test.ts — 8 passed.

UI proof (C5)

  • python3 docker/scripts/perc-devctl.py qa-up — TEST_CMS_URL=http://127.0.0.1:9993, container perc-matrix-cms-h2, RESULT:OK
  • qa-health healthy HTTP 200
  • qa-deploy-webui (modern SPA from this worktree) then qa-health again
  • The stock QA image omitted workflowName on site GET/PUT. qa-deploy-war-jars --restart-jetty copied the worktree perc-system, rest, and sitemanage SNAPSHOT jars into the Rhythmyx WAR and restarted Jetty in-cell (not docker restart). qa-health healthy again. PUT then returned workflowName.
  • cd modules/perc-qa-automation/frontend && rtk npm run test:surface -- --path tests/publishing/siteDefaultWorkflow.spec.js with TEST_CMS_URL, ADMIN_USERNAME=Admin, TEST_DB_TYPE=h2, TEST_PRODUCT=cms — 1 passed
  • console-clean=yes (spec fails on pageerror / console error; expected 400/403/409 fetch noise ignored)
  • server.log-clean=yes (no ERROR/FATAL lines in /opt/Percussion/jetty/base/logs/server.log after the run)

Pre-push local code review

Summary

Machine analysis found 0 finding(s), 0 bug(s).

Scope

  • Base: origin/main
  • Head: HEAD
  • Files: 9 analyzed
  • Persona: erlang 0.1.1
  • Persona source: /home/nate/.local/share/mkd/agents/erlang

Recommendation

approve

Gate

  • Blocking bugs: 0
  • May commit/push: yes

Issues

No issues.

Co-Authored by Grok Build 1.0.46 using grok-4.6 with agent night-issue-prs-erlang.

PublishingShell chooses a catalog workflow and saves it with PUT
/services/sites. Cancel, an empty choice, and HTTP 400/403/409 do not
claim success.

Fixes #5061

> Co-Authored by Grok Build 1.0.46 using grok-4.6 with agent night-issue-prs.
…kflow

H2 sample sites already use the only stock workflow. The surface spec
creates a catalog workflow first so save, refresh, cancel, empty, and
409 are observable.

> Co-Authored by Grok Build 1.0.46 using grok-4.6 with agent night-issue-prs.
@natechadwick-intsof natechadwick-intsof added operator:grok Changes authored by Grok operator:night-issue-prs night-issue-prs workflow model:grok-4.6 Session model grok-4.6 labels Oct 2, 2026
> Co-Authored by Grok Build 1.0.46 using grok-4.6 with agent night-issue-prs-erlang.
@natechadwick-intsof

Copy link
Copy Markdown
Collaborator Author

Erlang 0.1.1 LGTM (same-login APPROVE rejected). 0 blocking bugs. Not merged: required checks still running after the review-report commit.

Co-Authored by Grok Build 1.0.46 using grok-4.6 with agent night-issue-prs-erlang.

@natechadwick-intsof

Copy link
Copy Markdown
Collaborator Author

LGTM. Same-login APPROVE is rejected by GitHub. Re-ran mkd-code-review 0.1.18 on head 15b26fe against origin/main (Persona: erlang 0.1.1, Persona source: ~/.local/share/mkd/agents/erlang). In-diff findings: 0 bugs. Recommendation: approve. Required checks on this snapshot are SUCCESS or skipped/neutral. Squash-merging.

Co-Authored by Grok Build 1.0.46 using grok-4.7 with agent night-issue-prs-erlang.

@natechadwick-intsof
natechadwick-intsof merged commit a258b09 into main Oct 2, 2026
8 checks passed
@natechadwick-intsof
natechadwick-intsof deleted the fix/issue-5061-site-default-workflow branch October 2, 2026 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

model:grok-4.6 Session model grok-4.6 operator:grok Changes authored by Grok operator:night-issue-prs night-issue-prs workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

issue 4531 slice 60: PublishingShell set the open site default workflow

1 participant