Skip to content

feat(publish): set the open site page-based flag (#5059) - #5066

Merged
natechadwick-intsof merged 4 commits into
mainfrom
fix/issue-5059-publish-page-based
Oct 2, 2026
Merged

natechadwick-intsof merged 4 commits into
mainfrom
fix/issue-5059-publish-page-based

Conversation

@natechadwick-intsof

@natechadwick-intsof natechadwick-intsof commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

PublishingShell can set whether the open site is page-based. Save sends PUT /services/sites/{nameOrId} with pageBasedSite only and shows yes or no after success, including after reopening the site. Cancel and an unchanged checkbox do not call the server. HTTP 400, 403, and 409 stay on the form and do not claim success. An omitted pageBasedSite does not clear the stored flag (the wire default false is not an implicit write).

Parent: #4531. Slice: #5059.

Operator: Grok: night-issue-prs (model grok-4.7)

Test plan

  • SitesAdaptorCreateUpdateDeleteTest omitted flag leaves stored true; explicit false persists
  • Vitest SitePageBasedPanel save, cancel, unchanged, and 400/403/409
  • Vitest sitePageBased parse/label/HTTP map
  • Playwright npm run test:surface -- --path tests/publishing/sitePageBased.spec.js — 1 passed
  • console-clean=yes (spec fails on pageerror / unexpected console error)
  • server.log-clean=yes (no ERROR/FATAL in /opt/Percussion/jetty/base/logs/server.log after the run)

Product documentation

  • Updated product-docs/8.2/admin/publishing.md (Set the open site page-based flag)

Maven

modules_built=rest,projects/sitemanage,WebUI

  • cd rest && JAVA_HOME=/usr/lib/jvm/java-21-openjdk bash ../mvnw clean install — BUILD SUCCESS. Tests run: 1585, Failures: 0
  • cd projects/sitemanage && JAVA_HOME=/usr/lib/jvm/java-21-openjdk bash ../../mvnw clean install — BUILD SUCCESS. Tests run: 3183, Failures: 0, Errors: 0, Skipped: 125
  • cd WebUI && JAVA_HOME=/usr/lib/jvm/java-21-openjdk bash ../mvnw clean install — BUILD SUCCESS. Vitest: Test Files 600 passed, Tests 5500 passed
  • rtk mvn could not spawn ./mvnw (permission denied); wrapper was invoked with bash. JDK 21.

downstream_checked=grep for extends Site / new Site() { found no anonymous subclasses. sitemanage clean install compiles against the new Site.isPageBasedSiteSpecified() method.

UI proof (C5)

  • python3 docker/scripts/perc-devctl.py qa-up — TEST_CMS_URL=http://127.0.0.1:9993, container perc-matrix-cms-h2
  • qa-health RESULT:OK HEALTH:healthy
  • qa-deploy-war-jars --restart-jetty (rest + sitemanage SNAPSHOT jars into the Rhythmyx WAR) and qa-deploy-webui
  • qa-health again RESULT:OK
  • cd modules/perc-qa-automation/frontend && TEST_CMS_URL=http://127.0.0.1:9993 ADMIN_USERNAME=Admin TEST_DB_TYPE=h2 TEST_PRODUCT=cms npm run test:surface -- --path tests/publishing/sitePageBased.spec.js — 1 passed
  • console-clean=yes
  • server.log-clean=yes

Pre-push local code review

Summary

Machine analysis found 0 finding(s), 0 bug(s).

Scope

  • Base: origin/main
  • Head: HEAD
  • Files: 13 analyzed
  • Persona: erlang 0.1.1
  • Persona source: /home/nate/.local/share/mkd/agents/erlang

Recommendation

approve

Gate

  • Blocking bugs: 0
  • May commit/push: yes

Issues

No issues.

PublishingShell saves pageBasedSite on the open site and shows the stored
value after success. Cancel does not call PUT. HTTP 400/403/409 stay on the
form. Omitted pageBasedSite does not clear the stored flag.

Fixes #5059

> Co-Authored by Grok Build 1.0.46 using grok-4.7 with agent night-issue-prs.
> Co-Authored by Grok Build 1.0.46 using grok-4.7 with agent night-issue-prs.
The surface spec was asserting the em dash before GET finished.

> Co-Authored by Grok Build 1.0.46 using grok-4.7 with agent night-issue-prs.
@natechadwick-intsof natechadwick-intsof added operator:grok Changes authored by Grok operator:night-issue-prs night-issue-prs workflow model:grok-4.7 Session model grok-4.7 labels Oct 2, 2026
Pre-push mkd-code-review analyze (percussion, advisory) against origin/main.

> Co-Authored by Grok Build 1.0.46 using grok-4.7 with agent night-issue-prs-erlang.
@natechadwick-intsof

Copy link
Copy Markdown
Collaborator Author

Erlang 0.1.1 LGTM. Same-login GitHub APPROVE is rejected, so this comment is the review record. mkd-code-review (percussion, advisory, origin/main): 0 in-diff bugs. Preexisting path and complexity rows do not block. Full report is under Pre-push local code review and in docs/ai-generated/code-reviews/pr-5066-erlang.md.

Co-Authored by Grok Build 1.0.46 using grok-4.7 with agent night-issue-prs-erlang.

@natechadwick-intsof
natechadwick-intsof merged commit 453be8e into main Oct 2, 2026
8 checks passed
@natechadwick-intsof
natechadwick-intsof deleted the fix/issue-5059-publish-page-based branch October 2, 2026 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

model:grok-4.7 Session model grok-4.7 operator:grok Changes authored by Grok operator:night-issue-prs night-issue-prs workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant