Repository navigation
feat(publish): set the open site page-based flag (#5059) - #5066
Merged
Merged
Conversation
PublishingShell saves pageBasedSite on the open site and shows the stored value after success. Cancel does not call PUT. HTTP 400/403/409 stay on the form. Omitted pageBasedSite does not clear the stored flag. Fixes #5059 > Co-Authored by Grok Build 1.0.46 using grok-4.7 with agent night-issue-prs.
> Co-Authored by Grok Build 1.0.46 using grok-4.7 with agent night-issue-prs.
The surface spec was asserting the em dash before GET finished. > Co-Authored by Grok Build 1.0.46 using grok-4.7 with agent night-issue-prs.
Pre-push mkd-code-review analyze (percussion, advisory) against origin/main. > Co-Authored by Grok Build 1.0.46 using grok-4.7 with agent night-issue-prs-erlang.
Collaborator
Author
|
Erlang 0.1.1 LGTM. Same-login GitHub APPROVE is rejected, so this comment is the review record. mkd-code-review (percussion, advisory,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PublishingShell can set whether the open site is page-based. Save sends
PUT /services/sites/{nameOrId}withpageBasedSiteonly and shows yes or no after success, including after reopening the site. Cancel and an unchanged checkbox do not call the server. HTTP 400, 403, and 409 stay on the form and do not claim success. An omittedpageBasedSitedoes not clear the stored flag (the wire defaultfalseis not an implicit write).Parent: #4531. Slice: #5059.
Operator: Grok: night-issue-prs (model grok-4.7)
Test plan
SitesAdaptorCreateUpdateDeleteTestomitted flag leaves storedtrue; explicitfalsepersistsSitePageBasedPanelsave, cancel, unchanged, and 400/403/409sitePageBasedparse/label/HTTP mapnpm run test:surface -- --path tests/publishing/sitePageBased.spec.js— 1 passed/opt/Percussion/jetty/base/logs/server.logafter the run)Product documentation
product-docs/8.2/admin/publishing.md(Set the open site page-based flag)Maven
modules_built=rest,projects/sitemanage,WebUI
cd rest && JAVA_HOME=/usr/lib/jvm/java-21-openjdk bash ../mvnw clean install— BUILD SUCCESS. Tests run: 1585, Failures: 0cd projects/sitemanage && JAVA_HOME=/usr/lib/jvm/java-21-openjdk bash ../../mvnw clean install— BUILD SUCCESS. Tests run: 3183, Failures: 0, Errors: 0, Skipped: 125cd WebUI && JAVA_HOME=/usr/lib/jvm/java-21-openjdk bash ../mvnw clean install— BUILD SUCCESS. Vitest: Test Files 600 passed, Tests 5500 passedrtk mvncould not spawn./mvnw(permission denied); wrapper was invoked with bash. JDK 21.downstream_checked=grep for
extends Site/new Site() {found no anonymous subclasses. sitemanage clean install compiles against the newSite.isPageBasedSiteSpecified()method.UI proof (C5)
python3 docker/scripts/perc-devctl.py qa-up— TEST_CMS_URL=http://127.0.0.1:9993, container perc-matrix-cms-h2qa-healthRESULT:OK HEALTH:healthyqa-deploy-war-jars --restart-jetty(rest + sitemanage SNAPSHOT jars into the Rhythmyx WAR) andqa-deploy-webuiqa-healthagain RESULT:OKcd modules/perc-qa-automation/frontend && TEST_CMS_URL=http://127.0.0.1:9993 ADMIN_USERNAME=Admin TEST_DB_TYPE=h2 TEST_PRODUCT=cms npm run test:surface -- --path tests/publishing/sitePageBased.spec.js— 1 passedPre-push local code review
Summary
Machine analysis found 0 finding(s), 0 bug(s).
Scope
Recommendation
approve
Gate
Issues
No issues.