feat: PublishingShell edits the open site protocol (#5001)

[natechadwick-intsof]

Summary

PublishingShell can edit the open site's protocol (http or https) and save it with the existing site update contract (PUT /services/sites/{nameOrId}, siteProtocol only). After reload the workspace shows the saved protocol. Cancel and an unchanged value do not write. HTTP 400, 403, and 409 stay on the form and do not claim success.

Parent: #4531. Slice: #5001. No new REST resource.

Operator: Grok: night-issue-prs (model unspecified)

Test plan

• Vitest: protocol match/invalid/HTTP failure helpers and SiteProtocolPanel save, cancel, unchanged, 400/403/409
• Surface Playwright on H2 QA: npm run test:surface -- --path tests/publishing/siteProtocol.spec.js — 1 passed
• Product docs: product-docs/8.2/admin/publishing.md

Product documentation

• Updated pages under product-docs/8.2/admin/publishing.md (Edit the open site protocol)

Maven (C3)

• modules_built: WebUI
• downstream_checked: none (no public Java signature change; existing site PUT field)
• Command: cd WebUI && TMPDIR=<worktree>/tmp/mvn MAVEN_OPTS=-Djava.io.tmpdir=... rtk mvn install
• BUILD SUCCESS
• Vitest: Test Files 587 passed; Tests 5383 passed
• Surefire: Tests run: 69, Failures: 0, Errors: 0, Skipped: 0
• Pre-existing compiler/dependency warnings only; no new warnings from this change
• One earlier mvn clean install failed packaging with /tmp disk quota before tests finished a later retry; the successful install above included test-compile and the full Vitest/Surefire run. A middle clean install hit an unrelated flaky EditorHost focus assertion that passed on the successful retry.

UI proof (C5)

• python3 docker/scripts/perc-devctl.py qa-up → TEST_CMS_URL=http://127.0.0.1:9993
• qa-health RESULT:OK HTTP:200 HEALTH:healthy
• python3 docker/scripts/perc-devctl.py qa-deploy-webui then qa-health again RESULT:OK
• npm run test:surface -- --path tests/publishing/siteProtocol.spec.js — 1 passed (3.1s)
• console-clean=yes (spec asserts no pageerror/console error except expected 409)
• server.log-clean=yes (no ERROR/FATAL in the cell server log tail after the run)
• qa-down removed perc-matrix-cms-h2

Pre-push local code review

Summary

Machine analysis found 0 finding(s), 0 bug(s).

Scope

• Base: origin/main
• Head: HEAD
• Files: 9 analyzed
• Persona: erlang 0.1.1
• Persona source: /home/nate/.local/share/mkd/agents/erlang

Recommendation

approve

Gate

• Blocking bugs: 0
• May commit/push: yes

Issues

No issues.

Intent: existing site PUT (name + siteProtocol only). SitesAdaptor.applyWritableFields leaves omitted description and base URL unchanged. Vitest covers save/reload, cancel, unchanged, and HTTP 400/403/409. Surface Playwright covers cancel, 409, save, and reload. Product docs: product-docs/8.2/admin/publishing.md. No path I/O. No rule-file diffs.

Checks snapshot: 5 passed, 3 skipped, 0 failed. No unresolved review threads.

Fixes #5001

Co-Authored by Grok Build 1.0.46 using grok-4.7 with agent night-issue-prs-peer.

[natechadwick-intsof]

Erlang sub-agent LGTM; GitHub cannot record APPROVE on the author login; squash-merging as overnight Erlang.

mkd-code-review 0.1.18 (Persona erlang 0.1.1): 0 bugs, 9 files, base origin/main, head HEAD. Checks snapshot: 5 passed, 3 skipped, 0 failed. No unresolved review threads. PublishingShell site-protocol edit is the existing site PUT (siteProtocol only), with Vitest (save/reload, cancel, unchanged, 400/403/409), surface Playwright, and product-docs/8.2/admin/publishing.md.

Co-Authored by Grok Build 1.0.46 using grok-4.7 with agent night-issue-prs-peer.