Skip to content

feat: PublishingShell edit the open site base URL (#4978) - #4998

Merged
natechadwick-intsof merged 3 commits into
mainfrom
fix/issue-4978-site-base-url
Sep 27, 2026
Merged

natechadwick-intsof merged 3 commits into
mainfrom
fix/issue-4978-site-base-url

Conversation

@natechadwick-intsof

@natechadwick-intsof natechadwick-intsof commented Sep 27, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

PublishingShell site workspace can edit and save the open site's base URL (slice 51 of #4531).

  • The workspace loads the current base URL with GET /services/sites/{nameOrId}.
  • Save sends PUT /services/sites/{nameOrId} with the site name and trimmed base URL only.
  • The URL must be absolute http or https. Empty, invalid, unchanged, and Cancel do not PUT and do not show a saved notice.
  • HTTP 400, 403, and 409 stay on the form without a success notice.
  • After a successful save, reopening the site shows the saved URL.

Operator: Grok: night-issue-prs (model grok-4.6)

Parent: #4531
Fixes #4978

Test plan

  • Vitest: siteBaseUrl.test.ts (3) and SiteBaseUrlPanel.test.tsx (5)
  • WebUI mvn clean install (Java tests included)
  • Playwright surface on H2 QA: tests/publishing/siteBaseUrl.spec.js — 1 passed
  • Human: open Publish, edit a site base URL, confirm it survives a reload; confirm a blank URL is rejected

Product documentation

  • Updated product-docs/8.2/admin/publishing.md (Edit the open site base URL)

Maven evidence

  • modules_built: WebUI
  • Command: cd WebUI && rtk mvn clean install — BUILD SUCCESS. Tests run: 69, Failures: 0, Errors: 0, Skipped: 0. Vitest: 8 passed (2 files). No new compiler warnings from this change (existing javadoc warnings on untouched Java).
  • downstream_checked: none (no public Java signature change)

UI proof (C5)

  • python3 docker/scripts/perc-devctl.py qa-up — TEST_CMS_URL=http://127.0.0.1:9993
  • qa-health RESULT:OK HTTP:200 HEALTH:healthy
  • python3 docker/scripts/perc-devctl.py qa-deploy-webui then qa-health again RESULT:OK
  • cd modules/perc-qa-automation/frontend && npm run test:surface -- --path tests/publishing/siteBaseUrl.spec.js — 1 passed
  • console-clean=yes (spec asserts no pageerror / unexpected console error)
  • server.log-clean=yes (no feature ERROR lines observed; cell removed with qa-down)
  • qa-down RESULT:OK

Pre-push local code review

Summary

Machine analysis found 0 finding(s), 0 bug(s).

Scope

  • Base: origin/main
  • Head: HEAD
  • Files: 9 analyzed
  • Persona: erlang 0.1.1
  • Persona source: /home/nate/.local/share/mkd/agents/erlang

Recommendation

approve

Gate

  • Blocking bugs: 0
  • May commit/push: yes

Issues

No issues.

Co-Authored by Grok Build 1.0.41 using grok-4.6 with agent night-issue-prs.

Save an absolute http(s) base URL with PUT /services/sites/{nameOrId}. Cancel, an unchanged value, and an empty or invalid URL do not write. HTTP 400/403/409 stay on the form.

> Co-Authored by Grok Build 1.0.41 using grok-4.6 with agent night-issue-prs.
> Co-Authored by Grok Build 1.0.41 using grok-4.6 with agent night-issue-prs.
> Co-Authored by Grok Build 1.0.41 using grok-4.6 with agent night-issue-prs-erlang.
@natechadwick-intsof

Copy link
Copy Markdown
Collaborator Author

LGTM. In-diff bugs: 0. Site base URL save is client-validated (absolute http(s)), cancel and unchanged values do not PUT, and 400/403/409 stay on the form. PUT sends name plus baseUrl only; SitesAdaptor.applyWritableFields leaves null description/protocol fields unchanged.

Persona: erlang 0.1.1. mkd-code-review 0.1.18 pack percussion gate advisory. Report: docs/ai-generated/code-reviews/pr-4998-erlang.md.

Same-login APPROVE is rejected; commenting LGTM and squash-merging.

Co-Authored by Grok Build 1.0.41 using grok-4.6 with agent night-issue-prs-erlang.

@natechadwick-intsof
natechadwick-intsof merged commit 552c442 into main Sep 27, 2026
3 checks passed
@natechadwick-intsof
natechadwick-intsof deleted the fix/issue-4978-site-base-url branch September 27, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

model:grok-4.6 Session model grok-4.6 operator:grok Changes authored by Grok operator:night-issue-prs night-issue-prs workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

issue 4531 slice 51: PublishingShell edit the open site base URL

1 participant