Repository navigation
feat: PublishingShell edit the open site base URL (#4978) - #4998
Merged
Merged
Conversation
Save an absolute http(s) base URL with PUT /services/sites/{nameOrId}. Cancel, an unchanged value, and an empty or invalid URL do not write. HTTP 400/403/409 stay on the form.
> Co-Authored by Grok Build 1.0.41 using grok-4.6 with agent night-issue-prs.
> Co-Authored by Grok Build 1.0.41 using grok-4.6 with agent night-issue-prs.
> Co-Authored by Grok Build 1.0.41 using grok-4.6 with agent night-issue-prs-erlang.
Collaborator
Author
|
LGTM. In-diff bugs: 0. Site base URL save is client-validated (absolute http(s)), cancel and unchanged values do not PUT, and 400/403/409 stay on the form. PUT sends name plus baseUrl only; SitesAdaptor.applyWritableFields leaves null description/protocol fields unchanged. Persona: erlang 0.1.1. mkd-code-review 0.1.18 pack percussion gate advisory. Report: docs/ai-generated/code-reviews/pr-4998-erlang.md. Same-login APPROVE is rejected; commenting LGTM and squash-merging.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PublishingShell site workspace can edit and save the open site's base URL (slice 51 of #4531).
GET /services/sites/{nameOrId}.PUT /services/sites/{nameOrId}with the site name and trimmed base URL only.httporhttps. Empty, invalid, unchanged, and Cancel do not PUT and do not show a saved notice.Operator: Grok: night-issue-prs (model grok-4.6)
Parent: #4531
Fixes #4978
Test plan
siteBaseUrl.test.ts(3) andSiteBaseUrlPanel.test.tsx(5)mvn clean install(Java tests included)tests/publishing/siteBaseUrl.spec.js— 1 passedProduct documentation
product-docs/8.2/admin/publishing.md(Edit the open site base URL)Maven evidence
WebUIcd WebUI && rtk mvn clean install— BUILD SUCCESS. Tests run: 69, Failures: 0, Errors: 0, Skipped: 0. Vitest: 8 passed (2 files). No new compiler warnings from this change (existing javadoc warnings on untouched Java).UI proof (C5)
python3 docker/scripts/perc-devctl.py qa-up— TEST_CMS_URL=http://127.0.0.1:9993qa-healthRESULT:OK HTTP:200 HEALTH:healthypython3 docker/scripts/perc-devctl.py qa-deploy-webuithenqa-healthagain RESULT:OKcd modules/perc-qa-automation/frontend && npm run test:surface -- --path tests/publishing/siteBaseUrl.spec.js— 1 passedqa-downRESULT:OKPre-push local code review
Summary
Machine analysis found 0 finding(s), 0 bug(s).
Scope
Recommendation
approve
Gate
Issues
No issues.