Repository navigation
feat: PublishingShell create a site (#4959) - #4966
Merged
Merged
Conversation
Sites toolbar and empty state create a site, then open the workspace using the numeric id from the reloaded list. Cancel, blank, duplicate, and HTTP 400/403/409 stay on the list. > Co-Authored by Grok Build 1.0.41 using grok-4.7 with agent night-issue-prs.
> Co-Authored by Grok Build 1.0.41 using grok-4.7 with agent night-issue-prs.
natechadwick-intsof
added
operator:grok
Record the host mkd-code-review report. In-diff gate is clean. > Co-Authored by Grok Build 1.0.41 using grok-4.7 with agent night-issue-prs-erlang.
Collaborator
Author
|
LGTM. Host Erlang: mkd-code-review 0 in-diff bugs. Same-login APPROVE was rejected; commenting LGTM and squash-merging.
|
natechadwick-intsof
deleted the
fix/issue-4959-publishing-create-site
branch
September 27, 2026 03:25
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parent: #4531. PublishingShell Sites can create a site from the toolbar and the empty state. A valid name posts
POST /services/sites, reloads the list, and opens that site's workspace using the numeric site id. Cancel, a blank name, and a name already on the list do not create a site. HTTP 400/403/409 stay on the list and do not open a workspace. Rename (#4960) and copy (#4961) are not in this PR.Operator: Grok: night-issue-prs (model grok-4.7)
Fixes #4959
Test plan
SitesSection.create.test.tsx(create, cancel/blank, local duplicate, 400/403/409, empty-state action, no numeric id)tests/publishing/sitesCreate.spec.json H2 QAProduct documentation
product-docs/8.2/admin/publishing.md(Create a site)Pre-PR Maven
cd WebUI && rtk mvn clean install— BUILD SUCCESS. JavaTests run: 69, Failures: 0. VitestTest Files 573 passed,Tests 5263 passed.cd modules/perc-qa-automation && rtk mvn clean install— BUILD SUCCESS.No tests to run(Playwright is not the default Maven test phase).UI proof (C5)
python3 docker/scripts/perc-devctl.py qa-up— TEST_CMS_URL=http://127.0.0.1:9993, container perc-matrix-cms-h2qa-deploy-webuiafter WebUI clean install;qa-healthHTTP 200 healthy before the passing runnpm run test:surface -- --path tests/publishing/sitesCreate.spec.js— 1 passedqa-downremoved perc-matrix-cms-h2Pre-push local code review
Erlang review — PR 4966
Summary
Machine analysis found 0 finding(s), 0 bug(s).
Scope
Recommendation
approve
Gate
Issues
No issues.
Erlang (host)
In-diff bugs: none. Create, cancel, blank, duplicate, and HTTP 400/403/409 are covered by Vitest; Playwright covers the toolbar create path. Product doc updated. Recommendation: approve.