Skip to content

feat(publish): copy a log item location (#4937) - #4950

Merged
natechadwick-intsof merged 2 commits into
mainfrom
fix/issue-4937-copy-log-location
Sep 26, 2026
Merged

natechadwick-intsof merged 2 commits into
mainfrom
fix/issue-4937-copy-log-location

Conversation

@natechadwick-intsof

@natechadwick-intsof natechadwick-intsof commented Sep 26, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Parent: #4531. Slice #4937.

From PublishingShell log details, Copy location writes the published file location (or the file name when the location is blank) to the clipboard and shows Location copied. Dismiss clears that confirmation and does not change the log list or close details. A row with neither location nor file name shows No location to copy. A failed clipboard write shows Could not copy location and stays on the panel. No REST change (existing details payload already carries fileLocation / fileName).

Operator: Grok: night-issue-prs (model grok-4.7)

Fixes #4937

Test plan

  • Vitest logDetails.copy.test.tsx (location trim, file-name fallback, missing, clipboard false/throw, dismiss does not close)
  • Playwright H2 surface tests/publishing-log-copy-location.spec.js — 1 passed
  • WebUI and perc-qa-automation standalone clean install

Product documentation

  • Updated product-docs/8.2/admin/publishing.md (Copy location on a log item row)

Pre-PR Maven verification

  • modules_built: WebUI, modules/perc-qa-automation
  • cd WebUI && JAVA_HOME=/usr/lib/jvm/java-21-openjdk ../mvnw clean install (via rtk mvn) — BUILD SUCCESS. Surefire Tests run: 69, Failures: 0. Vitest Test Files 570 passed, Tests 5227 passed.
  • cd modules/perc-qa-automation && rtk mvn clean install — BUILD SUCCESS. No Java tests to run (npm ci only).
  • downstream_checked: none (no public Java/API signature change; UI-only copy helper)
  • No new compiler warnings attributable to this change (pre-existing npm EBADENGINE notices on the WebUI frontend toolchain).

UI proof (C5)

  • python3 docker/scripts/perc-devctl.py qa-up — TEST_CMS_URL=http://127.0.0.1:9993, container perc-matrix-cms-h2, qa-health RESULT:OK HEALTH:healthy
  • Hot-copied WebUI/target/generated-webui/cm/modern/assets/ into the QA WAR cm/modern/assets/ (full tree; entry chunk hashes must match). qa-health again RESULT:OK. No Jetty/container restart.
  • TEST_CMS_URL=http://127.0.0.1:9993 ADMIN_USERNAME=Admin TEST_DB_TYPE=h2 TEST_PRODUCT=cms npm run test:surface -- --path tests/publishing-log-copy-location.spec.js — 1 passed
  • console-clean=yes (spec asserts no pageerror / console error)
  • server.log-clean=yes (no ERROR/FATAL in the tail of the QA cell server.log after the run)

Pre-push local code review

Summary

Machine analysis found 0 finding(s), 0 bug(s).

Scope

  • Base: origin/main
  • Head: HEAD
  • Files: 7 analyzed
  • Persona: erlang 0.1.1
  • Persona source: /home/nate/.local/share/mkd/agents/erlang

Recommendation

approve

Gate

  • Blocking bugs: 0
  • May commit/push: yes

Issues

No issues.

Co-Authored by Grok Build 1.0.41 using grok-4.7 with agent night-issue-prs-erlang.

Operators can copy a publish log item's file location (or file name) and
see a confirmation. A blank location or a failed clipboard write stays on
the details panel and does not claim success. Dismiss does not change logs.

> Co-Authored by Grok Build 1.0.41 using grok-4.7 with agent night-issue-prs.
Advisory gate: 0 findings, 0 bugs. Approve.

> Co-Authored by Grok Build 1.0.41 using grok-4.7 with agent night-issue-prs-erlang.
@natechadwick-intsof

Copy link
Copy Markdown
Collaborator Author

LGTM. Erlang advisory gate: no in-diff blocking bugs (preexisting complexity/path rows do not block). Same-account APPROVE is not available; squash-merge as reviewer of record.

Co-Authored by Grok Build 1.0.41 using grok-4.7 with agent night-issue-prs-erlang.

@natechadwick-intsof
natechadwick-intsof merged commit 1ac785d into main Sep 26, 2026
6 checks passed
@natechadwick-intsof
natechadwick-intsof deleted the fix/issue-4937-copy-log-location branch September 26, 2026 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

model:grok-4.7 Session model grok-4.7 operator:grok Changes authored by Grok operator:night-issue-prs night-issue-prs workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

issue 4531 slice 44: PublishingShell copy a log item location

1 participant