Repository navigation
feat(publish): copy a log item location (#4937) - #4950
Merged
Merged
Conversation
Operators can copy a publish log item's file location (or file name) and see a confirmation. A blank location or a failed clipboard write stays on the details panel and does not claim success. Dismiss does not change logs. > Co-Authored by Grok Build 1.0.41 using grok-4.7 with agent night-issue-prs.
Advisory gate: 0 findings, 0 bugs. Approve. > Co-Authored by Grok Build 1.0.41 using grok-4.7 with agent night-issue-prs-erlang.
Collaborator
Author
|
LGTM. Erlang advisory gate: no in-diff blocking bugs (preexisting complexity/path rows do not block). Same-account APPROVE is not available; squash-merge as reviewer of record.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parent: #4531. Slice #4937.
From PublishingShell log details, Copy location writes the published file location (or the file name when the location is blank) to the clipboard and shows Location copied. Dismiss clears that confirmation and does not change the log list or close details. A row with neither location nor file name shows No location to copy. A failed clipboard write shows Could not copy location and stays on the panel. No REST change (existing details payload already carries
fileLocation/fileName).Operator: Grok: night-issue-prs (model grok-4.7)
Fixes #4937
Test plan
logDetails.copy.test.tsx(location trim, file-name fallback, missing, clipboard false/throw, dismiss does not close)tests/publishing-log-copy-location.spec.js— 1 passedclean installProduct documentation
product-docs/8.2/admin/publishing.md(Copy location on a log item row)Pre-PR Maven verification
WebUI,modules/perc-qa-automationcd WebUI && JAVA_HOME=/usr/lib/jvm/java-21-openjdk ../mvnw clean install(viartk mvn) — BUILD SUCCESS. Surefire Tests run: 69, Failures: 0. Vitest Test Files 570 passed, Tests 5227 passed.cd modules/perc-qa-automation && rtk mvn clean install— BUILD SUCCESS. No Java tests to run (npm ci only).UI proof (C5)
python3 docker/scripts/perc-devctl.py qa-up— TEST_CMS_URL=http://127.0.0.1:9993, container perc-matrix-cms-h2, qa-health RESULT:OK HEALTH:healthyWebUI/target/generated-webui/cm/modern/assets/into the QA WARcm/modern/assets/(full tree; entry chunk hashes must match). qa-health again RESULT:OK. No Jetty/container restart.TEST_CMS_URL=http://127.0.0.1:9993 ADMIN_USERNAME=Admin TEST_DB_TYPE=h2 TEST_PRODUCT=cms npm run test:surface -- --path tests/publishing-log-copy-location.spec.js— 1 passedserver.logafter the run)Pre-push local code review
Summary
Machine analysis found 0 finding(s), 0 bug(s).
Scope
Recommendation
approve
Gate
Issues
No issues.