Skip to content

fix(webui): hide publish-log Open in editor without a content id (#4936) - #4946

Merged
natechadwick-intsof merged 2 commits into
mainfrom
fix/issue-4936-log-item-no-id
Sep 26, 2026
Merged

natechadwick-intsof merged 2 commits into
mainfrom
fix/issue-4936-log-item-no-id

Conversation

@natechadwick-intsof

@natechadwick-intsof natechadwick-intsof commented Sep 26, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Parent: #4531. Slice #4936.

PublishingShell log details already opened a content id in the React editor (EditorHost via spa.jsp?entry=editor). This slice hides Open in editor when the log item has no content id. The log list stays on screen. HTTP 403/404 from the fields probe still stay on the item detail and do not open a blank editor window.

Operator: Grok: night-issue-prs (model grok-4.6)

Test plan

  • Vitest openLogItemInEditor.test.tsx (5 tests) including hide-when-no-id
  • cd WebUI && rtk mvn clean install — BUILD SUCCESS. Java Tests run: 69, Failures: 0. Vitest Tests 5213 passed (569 files)
  • cd modules/perc-qa-automation && rtk mvn clean install — BUILD SUCCESS. No tests to run (Playwright is not the default Surefire suite)
  • Playwright H2 QA: python3 docker/scripts/perc-devctl.py qa-up then qa-health RESULT:OK HEALTH:healthy TEST_CMS_URL=http://127.0.0.1:9993 QA_CONTAINER=perc-matrix-cms-h2. Copied WebUI/target/generated-webui/cm/modern/assets into the Rhythmyx WAR cm/modern/assets (no docker restart). qa-health again RESULT:OK. rtk npm run test:surface -- --path tests/publishing-log-open-editor.spec.js — 4 passed. console-clean=yes. server.log-clean=yes (no ERROR/FATAL in the test window). qa-down RESULT:OK

Product documentation

  • Updated product-docs/8.2/admin/publishing.md (Logs: no content id has no Open in editor; log list stays on screen)

C3 evidence

  • modules_built: WebUI, modules/perc-qa-automation
  • downstream_checked: none (no public Java signature change; UI predicate only)
  • build_evidence: see Test plan

Pre-push local code review

Erlang review — PR #4946

Independent pre-merge review (not the author). mkd-code-review 0.1.18, pack percussion, --gate advisory, --git-base origin/main, models ollama-dev-coder.

CLI stdout

Summary

Machine analysis found 1 finding(s), 0 bug(s).

Scope

  • Base: origin/main
  • Head: HEAD
  • Files: 6 analyzed
  • Persona: erlang 0.1.1
  • Persona source: /home/nate/.local/share/mkd/agents/erlang

Recommendation

approve

Gate

  • Blocking bugs: 0
  • May commit/push: yes

Issues

Issue 1 -- Severity: suggestion

  • File: product-docs/8.2/admin/publishing.md:205
  • Rule: llm.ollama-dev-coder
  • Tool: llm
  • Description: The documentation should mention that the 'Open in editor' action is hidden for rows with no content id.
  • Suggestion: Update the documentation to include a note about hiding the 'Open in editor' action for rows without a content id.
  • Status: open

Co-Authored by Grok Build 1.0.41 using grok-4.6 with agent night-issue-prs-erlang.

PublishingShell log item detail offers Open in editor only when the row
has a content id. The log list stays on screen (#4936).

> Co-Authored by Grok Build 1.0.41 using grok-4.6 with agent night-issue-prs.
Durable mkd-code-review markdown for the open PR. Advisory gate, zero in-diff bugs.

> Co-Authored by Grok Build 1.0.41 using grok-4.6 with agent night-issue-prs-erlang.
@natechadwick-intsof

Copy link
Copy Markdown
Collaborator Author

LGTM. mkd-code-review advisory gate: 0 in-diff blocking bugs (preexisting path rows do not block). Same-login APPROVE was rejected, so this comment records the review. Full report is in the PR body under Pre-push local code review and docs/ai-generated/code-reviews/pr-4946-erlang.md.

Co-Authored by Grok Build 1.0.41 using grok-4.6 with agent night-issue-prs-erlang.

@natechadwick-intsof
natechadwick-intsof merged commit 11c2911 into main Sep 26, 2026
8 checks passed
@natechadwick-intsof
natechadwick-intsof deleted the fix/issue-4936-log-item-no-id branch September 26, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

model:grok-4.6 Session model grok-4.6 operator:grok Changes authored by Grok operator:night-issue-prs night-issue-prs workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant