Repository navigation
fix(webui): hide publish-log Open in editor without a content id (#4936) - #4946
Merged
Merged
Conversation
PublishingShell log item detail offers Open in editor only when the row has a content id. The log list stays on screen (#4936). > Co-Authored by Grok Build 1.0.41 using grok-4.6 with agent night-issue-prs.
Durable mkd-code-review markdown for the open PR. Advisory gate, zero in-diff bugs. > Co-Authored by Grok Build 1.0.41 using grok-4.6 with agent night-issue-prs-erlang.
Collaborator
Author
|
LGTM. mkd-code-review advisory gate: 0 in-diff blocking bugs (preexisting path rows do not block). Same-login APPROVE was rejected, so this comment records the review. Full report is in the PR body under Pre-push local code review and docs/ai-generated/code-reviews/pr-4946-erlang.md.
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parent: #4531. Slice #4936.
PublishingShell log details already opened a content id in the React editor (
EditorHostviaspa.jsp?entry=editor). This slice hides Open in editor when the log item has no content id. The log list stays on screen. HTTP 403/404 from the fields probe still stay on the item detail and do not open a blank editor window.Operator: Grok: night-issue-prs (model grok-4.6)
Test plan
openLogItemInEditor.test.tsx(5 tests) including hide-when-no-idcd WebUI && rtk mvn clean install— BUILD SUCCESS. Java Tests run: 69, Failures: 0. Vitest Tests 5213 passed (569 files)cd modules/perc-qa-automation && rtk mvn clean install— BUILD SUCCESS. No tests to run (Playwright is not the default Surefire suite)python3 docker/scripts/perc-devctl.py qa-upthenqa-healthRESULT:OK HEALTH:healthy TEST_CMS_URL=http://127.0.0.1:9993 QA_CONTAINER=perc-matrix-cms-h2. CopiedWebUI/target/generated-webui/cm/modern/assetsinto the Rhythmyx WARcm/modern/assets(no docker restart).qa-healthagain RESULT:OK.rtk npm run test:surface -- --path tests/publishing-log-open-editor.spec.js— 4 passed. console-clean=yes. server.log-clean=yes (no ERROR/FATAL in the test window).qa-downRESULT:OKProduct documentation
product-docs/8.2/admin/publishing.md(Logs: no content id has no Open in editor; log list stays on screen)C3 evidence
Pre-push local code review
Erlang review — PR #4946
Independent pre-merge review (not the author). mkd-code-review 0.1.18, pack percussion, --gate advisory, --git-base origin/main, models ollama-dev-coder.
CLI stdout
Summary
Machine analysis found 1 finding(s), 0 bug(s).
Scope
Recommendation
approve
Gate
Issues
Issue 1 -- Severity: suggestion
llm.ollama-dev-coderllm