Repository navigation
fix(publish): filter status jobs by edition name - #4933
Merged
Merged
Conversation
Status narrows the loaded job list by edition name (case-insensitive) without a new request. Clearing the box restores the site-scoped list. An empty match is not an error, and HTTP 403 on a later reload stays on the Status panel. Fixes #4914 > Co-Authored by Grok Build 1.0.41 using grok-4.6 with agent night-issue-prs.
> Co-Authored by Grok Build 1.0.41 using grok-4.6 with agent night-issue-prs.
This was referenced Sep 26, 2026
> Co-Authored by Grok Build 1.0.41 using grok-4.6 with agent night-issue-prs-erlang.
Collaborator
Author
|
LGTM. Independent Erlang review (persona erlang 0.1.1, mkd-code-review 0.1.18, pack percussion, gate advisory). Machine findings: 0 bugs / 7 files. No missing behavioral tests, path portability issues, or change-class gaps. Same-login APPROVE is rejected by GitHub; this comment is the LGTM. Report: docs/ai-generated/code-reviews/pr-4933-erlang.md (66c24df). |
natechadwick-intsof
deleted the
fix/issue-4914-status-edition-filter
branch
September 26, 2026 13:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Publishing Status can filter the already-loaded job list by edition name (case-insensitive contains). Clearing the box restores the list still narrowed by the site filter. An empty match is an empty state, not an error. A later reload that returns HTTP 403 keeps the Status panel and shows the error.
Parent: #4531. Fixes #4914.
Operator: Grok: night-issue-prs (model grok-4.6)
Test plan
statusEditionFilter.test.tsx(blank query, case-insensitive match, site filter kept when edition filter clears, 403 reload stays on the panel)tests/publishing/statusEditionFilter.spec.json H2 QAProduct documentation
product-docs/8.2/admin/publishing.md(Filter editions on Status)Maven / UI proof
modules_built: WebUI, modules/perc-qa-automation
cd WebUI && rtk mvn clean install— BUILD SUCCESS. Surefire Tests run: 69, Failures: 0. Vitest Test Files 567 passed, Tests 5199 passed.cd modules/perc-qa-automation && rtk mvn clean install— BUILD SUCCESS. No tests to run (Playwright is not the default Maven test phase).C5:
python3 docker/scripts/perc-devctl.py qa-up— TEST_CMS_URL=http://127.0.0.1:9993, container perc-matrix-cms-h2python3 docker/scripts/perc-devctl.py qa-healthafter in-cell StopJetty/StartJetty followingqa-deploy-webui— RESULT:OK HTTP:200 HEALTH:healthyrtk npm run test:surface -- --path tests/publishing/statusEditionFilter.spec.js— 1 passedqa-downafter the runPre-push local code review
Summary
Machine analysis found 0 finding(s), 0 bug(s).
Scope
Recommendation
approve
Gate
Issues
No issues.