Skip to content

feat(editor): take down the open item from EditorHost (#4862) - #4876

Merged
natechadwick-intsof merged 3 commits into
mainfrom
fix/issue-4862-editor-takedown
Sep 25, 2026
Merged

natechadwick-intsof merged 3 commits into
mainfrom
fix/issue-4862-editor-takedown

Conversation

@natechadwick-intsof

@natechadwick-intsof natechadwick-intsof commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Parent: #4532. Slice #4862.

EditorHost Take down unpublishes the already-open page or asset after confirm, using the existing sitemanage takedown API (GET, or PUT of linked pages when that list is non-empty). Success and server errors (including HTTP 200 FORBIDDEN) are shown on the host. Cancel does not call takedown. View mode, folders, templates, and a new unsaved item (no content id) have no Take down control.

Operator: Grok: night-issue-prs (model grok-4.6)

Test plan

  • Vitest: confirm + linked paths, cancel, FORBIDDEN, view/new item hidden, folder hidden (EditorHost.test.tsx); GET/PUT takedown URLs (editorPublish.test.ts)
  • Playwright surface tests/editor-host-takedown.spec.js (5 passed) on H2 QA
  • Node unit helper tests/unit/editor-host-takedown.test.js

Product documentation

  • Updated product-docs/8.2/admin/publishing.md (EditorHost Take down)

Pre-PR Maven

  • modules_built: WebUI
  • cd WebUI && JAVA_HOME=/usr/lib/jvm/java-21-openjdk rtk mvn clean install — BUILD SUCCESS. Tests run: 69, Failures: 0. Vitest (editorPublish + EditorHost): 120 passed.
  • downstream_checked: none (no Java public/protected signature change)
  • perc-qa-automation: node --test tests/unit/editor-host-takedown.test.js — 2 passed. No Java sources changed.

UI proof (C5)

  • python docker/scripts/perc-devctl.py qa-up — TEST_CMS_URL=http://127.0.0.1:9993 RESULT:OK
  • qa-health RESULT:OK HTTP:200 HEALTH:healthy
  • qa-deploy-webui then qa-health again RESULT:OK
  • npm run test:surface -- --path tests/editor-host-takedown.spec.js — 5 passed
  • console-clean=yes (pageerror/console error listeners empty on the confirm path)
  • server.log-clean=yes for takedown (install-time empty-H2 SQL noise and fake id 42/99 workflow lookups from unstubbed earlier attempts only; not takedown failures)
  • qa-down RESULT:OK

Pre-push local code review

Erlang review — PR #4876

Scope

  • Persona: erlang 0.1.1
  • Persona source: /home/nate/.local/share/mkd/agents/erlang
  • Status: mkd-code-review 0.1.18, pack percussion, --gate advisory, --git-base origin/main
  • PR: feat(editor): take down the open item from EditorHost (#4862) #4876
  • Base: origin/main (a8e5777)
  • Head: 8b7cfad
  • Files analyzed: 11
  • Erlang gate: no in-diff bugs, missing behavioral tests, or non-portable paths. Blocking bugs: 0. May commit/push: yes.

CLI stdout (mkd-code-review analyze --format markdown)

Summary

Machine analysis found 0 finding(s), 0 bug(s).

Scope

  • Base: origin/main
  • Head: HEAD
  • Files: 11 analyzed
  • Persona: erlang 0.1.1
  • Persona source: /home/nate/.local/share/mkd/agents/erlang

Recommendation

approve

Gate

  • Blocking bugs: 0
  • May commit/push: yes

Issues

No issues.

Fixes #4862

Co-Authored by Grok Build 1.0.41 using grok-4.6 with agent night-issue-prs.

Confirm, then call the existing sitemanage page/resource takedown API and show success or the server error. Folders, view mode, and a new unsaved item have no Take down control.

> Co-Authored by Grok Build 1.0.41 using grok-4.6 with agent night-issue-prs.
> Co-Authored by Grok Build 1.0.41 using grok-4.6 with agent night-issue-prs.
> Co-Authored by Grok Build 1.0.41 using grok-4.6 with agent night-issue-prs-erlang.
@natechadwick-intsof

Copy link
Copy Markdown
Collaborator Author

LGTM. Erlang 0.1.1 / mkd-code-review 0.1.18 against origin/main: 0 findings, 0 blocking bugs. Full report is in the PR body under Pre-push local code review and in docs/ai-generated/code-reviews/pr-4876-erlang.md (d257b75).

Not merged on this pass: required checks were still in progress (one snapshot), and mergeability went UNKNOWN after #4875 landed (both touch product-docs/8.2/admin/publishing.md). Same-login APPROVE is rejected by GitHub.

Co-Authored by Grok Build 1.0.41 using grok-4.6 with agent night-issue-prs-erlang.

@natechadwick-intsof
natechadwick-intsof merged commit abf6207 into main Sep 25, 2026
8 checks passed
@natechadwick-intsof
natechadwick-intsof deleted the fix/issue-4862-editor-takedown branch September 25, 2026 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

model:grok-4.6 Session model grok-4.6 operator:grok Changes authored by Grok operator:night-issue-prs night-issue-prs workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

issue 4532 slice 35: EditorHost takedown the open item

1 participant