Repository navigation
feat(editor): take down the open item from EditorHost (#4862) - #4876
Merged
Merged
Conversation
Confirm, then call the existing sitemanage page/resource takedown API and show success or the server error. Folders, view mode, and a new unsaved item have no Take down control. > Co-Authored by Grok Build 1.0.41 using grok-4.6 with agent night-issue-prs.
> Co-Authored by Grok Build 1.0.41 using grok-4.6 with agent night-issue-prs.
> Co-Authored by Grok Build 1.0.41 using grok-4.6 with agent night-issue-prs-erlang.
Collaborator
Author
|
LGTM. Erlang 0.1.1 / mkd-code-review 0.1.18 against origin/main: 0 findings, 0 blocking bugs. Full report is in the PR body under Pre-push local code review and in Not merged on this pass: required checks were still in progress (one snapshot), and mergeability went UNKNOWN after #4875 landed (both touch
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parent: #4532. Slice #4862.
EditorHost Take down unpublishes the already-open page or asset after confirm, using the existing sitemanage takedown API (GET, or PUT of linked pages when that list is non-empty). Success and server errors (including HTTP 200
FORBIDDEN) are shown on the host. Cancel does not call takedown. View mode, folders, templates, and a new unsaved item (no content id) have no Take down control.Operator: Grok: night-issue-prs (model grok-4.6)
Test plan
EditorHost.test.tsx); GET/PUT takedown URLs (editorPublish.test.ts)tests/editor-host-takedown.spec.js(5 passed) on H2 QAtests/unit/editor-host-takedown.test.jsProduct documentation
product-docs/8.2/admin/publishing.md(EditorHost Take down)Pre-PR Maven
cd WebUI && JAVA_HOME=/usr/lib/jvm/java-21-openjdk rtk mvn clean install— BUILD SUCCESS. Tests run: 69, Failures: 0. Vitest (editorPublish + EditorHost): 120 passed.node --test tests/unit/editor-host-takedown.test.js— 2 passed. No Java sources changed.UI proof (C5)
python docker/scripts/perc-devctl.py qa-up— TEST_CMS_URL=http://127.0.0.1:9993 RESULT:OKqa-healthRESULT:OK HTTP:200 HEALTH:healthyqa-deploy-webuithenqa-healthagain RESULT:OKnpm run test:surface -- --path tests/editor-host-takedown.spec.js— 5 passedqa-downRESULT:OKPre-push local code review
Erlang review — PR #4876
Scope
CLI stdout (
mkd-code-review analyze --format markdown)Summary
Machine analysis found 0 finding(s), 0 bug(s).
Scope
Recommendation
approve
Gate
Issues
No issues.
Fixes #4862