Repository navigation
feat(publish): Runtime chrome uses the message catalog (#4837) - #4849
Merged
natechadwick-intsof merged 2 commits intoSep 25, 2026
Merged
Conversation
PublishingShell Runtime labels and prompts now go through the en-us publishing catalog instead of hardcoded English (#4837). > Co-Authored by Grok Build 1.0.41 using grok-4.7 with agent night-issue-prs.
This was referenced Sep 25, 2026
Records the mkd-code-review advisory pass (erlang 0.1.1) for this PR head. > Co-Authored by Grok Build 1.0.41 using grok-4.7 with agent night-issue-prs-erlang.
Collaborator
Author
|
LGTM. Erlang 0.1.1 advisory pass: no in-diff blocking bugs. Preexisting path/complexity rows do not gate. Report is in the PR body under Pre-push local code review and docs/ai-generated/code-reviews/pr-N-erlang.md.
|
natechadwick-intsof
deleted the
fix/issue-4837-runtime-message-catalog
branch
September 25, 2026 02:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parent: #4531 (slice 32 / #4837).
PublishingShell Runtime section labels that were raw English (Site, Publish server, Refresh, Idle, Start, Demand publish, content ids, Queue demand, Clear site record, Purge log, and related prompts) now resolve through the publishing message catalog. New units are en-us only. Site reuses the existing
perc.ui.publish.title@Siteunit.Operator: Grok: night-issue-prs (model grok-4.7)
Fixes #4837
Test plan
runtimeEditions.test.tsx: catalog stub returnsCATALOG_DEMAND_PUBLISHfor the demand heading key;{0}substitutiontests/publishing/runtimeEditions.spec.json H2 QA:I18N.messageresolves the demand key and the heading matchescd modules/perc-i18n && rtk mvn clean installBUILD SUCCESS (Tests run: 33, Failures: 0)cd WebUI && rtk mvn clean installBUILD SUCCESS (Surefire Tests run: 69, Failures: 0; VitestruntimeEditions.test.tsx7 passed)cd modules/perc-qa-automation && rtk mvn clean installBUILD SUCCESS (no Java tests; npm ci only; matrix-smoke not part of default install)product-docs/8.2/admin/publishing.mdProduct documentation
product-docs/8.2/admin/publishing.md(Runtime labels come from the catalog; en-us default)C3 evidence
cd modules/perc-i18n && rtk mvn clean installBUILD SUCCESS, Tests run: 33, Failures: 0cd WebUI && rtk mvn clean installBUILD SUCCESS, Surefire Tests run: 69, Failures: 0; focused Vitest 7 passedcd modules/perc-qa-automation && rtk mvn clean installBUILD SUCCESSC5 UI proof
python3 docker/scripts/perc-devctl.py qa-upTEST_CMS_URL=http://127.0.0.1:9993 QA_CMS_HOST_PORT=9993qa-healthRESULT:OK HTTP:200 HEALTH:healthyperc-i18n-8.2.0-SNAPSHOT.jarintoperc-matrix-cms-h2/opt/Percussion/jetty/base/webapps/Rhythmyx/WEB-INF/lib/python3 docker/scripts/perc-devctl.py qa-deploy-webuiqa-healthagain RESULT:OK HTTP:200 HEALTH:healthycd modules/perc-qa-automation/frontend && rtk npm run test:surface -- --path tests/publishing/runtimeEditions.spec.js— 2 passedPre-push local code review
Persona: erlang 0.1.1. Persona source: ~/.local/share/mkd/agents/erlang.
Erlang interpretation
LLM nits (import order, local fallback helper, dropped period on the empty-editions string) and the leftover English tokens "site cleared" / "log purged" inside catalogued last-result text are not blocking.
{0}substitution and the demand heading are covered by Vitest and Playwright. en-us-only TMX matches the issue. No new filesystem path I/O. No rule-file diffs.Gate: PASS
May commit/push: yes
CLI report
Summary
Machine analysis found 4 finding(s), 0 bug(s).
Scope
Recommendation
approve
Gate
Issues
Issue 1 -- Severity: suggestion
llm.ollama-dev-coderllmIssue 2 -- Severity: nit
llm.ollama-dev-coderllmIssue 3 -- Severity: nit
llm.ollama-dev-coderllmIssue 4 -- Severity: nit
llm.ollama-dev-coderllm