Skip to content

feat(publish): Runtime chrome uses the message catalog (#4837) - #4849

Merged
natechadwick-intsof merged 2 commits into
mainfrom
fix/issue-4837-runtime-message-catalog
Sep 25, 2026
Merged

natechadwick-intsof merged 2 commits into
mainfrom
fix/issue-4837-runtime-message-catalog

Conversation

@natechadwick-intsof

@natechadwick-intsof natechadwick-intsof commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Parent: #4531 (slice 32 / #4837).

PublishingShell Runtime section labels that were raw English (Site, Publish server, Refresh, Idle, Start, Demand publish, content ids, Queue demand, Clear site record, Purge log, and related prompts) now resolve through the publishing message catalog. New units are en-us only. Site reuses the existing perc.ui.publish.title@Site unit.

Operator: Grok: night-issue-prs (model grok-4.7)

Fixes #4837

Test plan

  • Vitest runtimeEditions.test.tsx: catalog stub returns CATALOG_DEMAND_PUBLISH for the demand heading key; {0} substitution
  • Playwright tests/publishing/runtimeEditions.spec.js on H2 QA: I18N.message resolves the demand key and the heading matches
  • cd modules/perc-i18n && rtk mvn clean install BUILD SUCCESS (Tests run: 33, Failures: 0)
  • cd WebUI && rtk mvn clean install BUILD SUCCESS (Surefire Tests run: 69, Failures: 0; Vitest runtimeEditions.test.tsx 7 passed)
  • cd modules/perc-qa-automation && rtk mvn clean install BUILD SUCCESS (no Java tests; npm ci only; matrix-smoke not part of default install)
  • Product documentation updated: product-docs/8.2/admin/publishing.md

Product documentation

  • Updated pages under product-docs/: product-docs/8.2/admin/publishing.md (Runtime labels come from the catalog; en-us default)

C3 evidence

  • modules_built: modules/perc-i18n, WebUI, modules/perc-qa-automation
  • downstream_checked: none (no public Java signature / final / sealed change)
  • build_evidence:
    • cd modules/perc-i18n && rtk mvn clean install BUILD SUCCESS, Tests run: 33, Failures: 0
    • cd WebUI && rtk mvn clean install BUILD SUCCESS, Surefire Tests run: 69, Failures: 0; focused Vitest 7 passed
    • cd modules/perc-qa-automation && rtk mvn clean install BUILD SUCCESS

C5 UI proof

  • python3 docker/scripts/perc-devctl.py qa-up TEST_CMS_URL=http://127.0.0.1:9993 QA_CMS_HOST_PORT=9993
  • qa-health RESULT:OK HTTP:200 HEALTH:healthy
  • docker cp perc-i18n-8.2.0-SNAPSHOT.jar into perc-matrix-cms-h2 /opt/Percussion/jetty/base/webapps/Rhythmyx/WEB-INF/lib/
  • python3 docker/scripts/perc-devctl.py qa-deploy-webui
  • in-cell StopJetty/StartJetty (not docker restart)
  • qa-health again RESULT:OK HTTP:200 HEALTH:healthy
  • cd modules/perc-qa-automation/frontend && rtk npm run test:surface -- --path tests/publishing/runtimeEditions.spec.js — 2 passed
  • console-clean=yes (spec fails on pageerror/console error)
  • server.log-clean=yes (no ERROR/FATAL after log truncate for this boot, excluding none)

Pre-push local code review

Persona: erlang 0.1.1. Persona source: ~/.local/share/mkd/agents/erlang.

Erlang interpretation

LLM nits (import order, local fallback helper, dropped period on the empty-editions string) and the leftover English tokens "site cleared" / "log purged" inside catalogued last-result text are not blocking. {0} substitution and the demand heading are covered by Vitest and Playwright. en-us-only TMX matches the issue. No new filesystem path I/O. No rule-file diffs.

Gate: PASS
May commit/push: yes

CLI report

Summary

Machine analysis found 4 finding(s), 0 bug(s).

Scope

  • Base: (unspecified)
  • Head: (unspecified)
  • Files: 5 analyzed
  • Persona: erlang 0.1.1
  • Persona source: /home/nate/.local/share/mkd/agents/erlang

Recommendation

approve

Gate

  • Blocking bugs: 0
  • May commit/push: yes

Issues

Issue 1 -- Severity: suggestion

  • File: WebUI/src/main/ts/publishing/sections/RuntimeSection.tsx:197
  • Rule: llm.ollama-dev-coder
  • Tool: llm
  • Description: English strings remain inside catalogued messages for 'site cleared' and 'log purged'.
  • Suggestion: Consider adding follow-up keys if a later slice catalogs these result tokens.
  • Status: open

Issue 2 -- Severity: nit

  • File: WebUI/src/main/ts/publishing/sections/RuntimeSection.tsx:41
  • Rule: llm.ollama-dev-coder
  • Tool: llm
  • Description: Imports should be grouped together at the top of the file.
  • Suggestion: Move the styles import up with the other imports.
  • Status: open

Issue 3 -- Severity: nit

  • File: WebUI/src/test/ts/publishing/runtimeEditions.test.tsx:21
  • Rule: llm.ollama-dev-coder
  • Tool: llm
  • Description: Local fallback function duplicates existing functionality in message.ts.
  • Suggestion: Import fallbackLabelFromKey from '@/i18n/message' and remove the local function.
  • Status: open

Issue 4 -- Severity: nit

  • File: modules/perc-i18n/src/main/resources/i18n/CmsUi.tmx:27534
  • Rule: llm.ollama-dev-coder
  • Tool: llm
  • Description: Empty-editions copy dropped the trailing period.
  • Suggestion: Restore the period in key + if intentional punctuation was removed.
  • Status: open

Co-Authored by Grok Build 1.0.41 using grok-4.7 with agent night-issue-prs-erlang.

PublishingShell Runtime labels and prompts now go through the en-us
publishing catalog instead of hardcoded English (#4837).

> Co-Authored by Grok Build 1.0.41 using grok-4.7 with agent night-issue-prs.
Records the mkd-code-review advisory pass (erlang 0.1.1) for this PR head.

> Co-Authored by Grok Build 1.0.41 using grok-4.7 with agent night-issue-prs-erlang.
@natechadwick-intsof

Copy link
Copy Markdown
Collaborator Author

LGTM. Erlang 0.1.1 advisory pass: no in-diff blocking bugs. Preexisting path/complexity rows do not gate. Report is in the PR body under Pre-push local code review and docs/ai-generated/code-reviews/pr-N-erlang.md.

Co-Authored by Grok Build 1.0.41 using grok-4.7 with agent night-issue-prs-erlang.

@natechadwick-intsof
natechadwick-intsof merged commit 6ae32e0 into main Sep 25, 2026
6 checks passed
@natechadwick-intsof
natechadwick-intsof deleted the fix/issue-4837-runtime-message-catalog branch September 25, 2026 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

model:grok-4.7 Session model grok-4.7 operator:grok Changes authored by Grok operator:night-issue-prs night-issue-prs workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

issue 4531 slice 32: PublishingShell runtime chrome uses the message catalog

1 participant