Skip to content

fix(publish): filter Publishing logs day window on the server - #4823

Merged
natechadwick-intsof merged 4 commits into
mainfrom
fix/issue-4809-logs-day-window
Sep 24, 2026
Merged

natechadwick-intsof merged 4 commits into
mainfrom
fix/issue-4809-logs-day-window

Conversation

@natechadwick-intsof

@natechadwick-intsof natechadwick-intsof commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Parent: #4531. Slice: #4809.

Publishing Logs no longer skips a day window or failures-only rows in the JVM after a capped load. PSSitePublishStatusService.buildLogs passes days, max count, skip, and failures-only into IPSPublisherService. The HQL adds an inclusive startDate >= :fromDate bound (days == -1 omits it) and, when failures-only, endingStatus in aborted, canceled, completed-with-failures, and restart-needed. Skip and max are Hibernate firstResult / maxResults.

Existing 4-arg *WithFilters methods still delegate with skip 0 and failures-only false (current-job lookback unchanged).

Operator: Grok: night-issue-prs (model grok-4.7)

Fixes #4809

Test plan

  1. cd system && JAVA_HOME=JDK21 ../mvnw clean install — BUILD SUCCESS, Tests run: 3101, Failures: 0 (includes PSPubStatusLogQueryTest 4 tests).
  2. cd projects/sitemanage && ../../mvnw clean install — BUILD SUCCESS, Tests run: 3068, Failures: 0 (includes PSSitePublishLogWindowTest).
  3. QA H2: python3 docker/scripts/perc-devctl.py qa-up → TEST_CMS_URL=http://127.0.0.1:9993 → qa-deploy-war-jars --restart-jetty → qa-health RESULT:OK HEALTH:healthy HTTP:200.
  4. npm run test:surface -- --path tests/publishing/logsDayWindow.spec.js — 1 passed. Console errors asserted empty. server.log tail had no ERROR/FATAL.

Checklist

  • Product documentation — updated product-docs/8.2/admin/publishing.md (Logs day window and failures-only are server query predicates).
  • Unit / module tests — PSPubStatusLogQueryTest, PSSitePublishLogWindowTest; system and sitemanage standalone clean install green.
  • WebUI + Playwright — modules/perc-qa-automation/frontend/tests/publishing/logsDayWindow.spec.js (posts days 3 and showOnlyFailures on SitePublishLogRequest). No WebUI source change; the days control already existed.
  • Build gates — system then sitemanage standalone clean install (no skipTests). New publisher overloads; grep found no other implements IPSPublisherService. sitemanage clean install is the reverse-dep compile.
  • Cross-platform — no new filesystem path joins. Date window is HQL.

Pre-push local code review

Summary

Machine analysis found 1 finding(s), 0 bug(s).

Scope

  • Base: origin/main
  • Head: HEAD
  • Files: 9 analyzed
  • In-diff: 0 finding(s); preexisting: 1
  • Persona: erlang 0.1.1
  • Persona source: /home/nate/.local/share/mkd/agents/erlang

Recommendation

approve

Gate

  • Blocking bugs: 0
  • May commit/push: yes

Issues

Issue 1 -- Severity: bug

  • File: projects/sitemanage/src/main/java/com/percussion/sitemanage/service/impl/PSSitePublishStatusService.java:365 (preexisting)
  • Rule: paths.hardcoded_sep
  • Tool: paths.hardcoded_sep
  • Pattern-id: paths.hardcoded-sep
  • Description: Possible non-portable path construction (line 365)
  • Suggestion: Use Path/PathBuf, path.join, File.separator, or pathSeparator — not literal / or \ joins.
  • Status: open

Summary

Machine analysis found 1 finding(s), 0 bug(s). LLM skipped (machine_only_mode)

Scope

  • Base: origin/main
  • Head: HEAD
  • Files: 9 analyzed
  • In-diff: 0 finding(s); preexisting: 1
  • Persona: erlang 0.1.1
  • Persona source: /home/nate/.local/share/mkd/agents/erlang

Recommendation

approve

Gate

  • Blocking bugs: 0
  • May commit/push: yes

Issues

Issue 1 -- Severity: bug

  • File: projects/sitemanage/src/main/java/com/percussion/sitemanage/service/impl/PSSitePublishStatusService.java:365 (preexisting)
  • Rule: paths.hardcoded_sep
  • Tool: paths.hardcoded_sep
  • Description: Possible non-portable path construction (line 365)
  • Status: open (preexisting dummy fixture; not in this hunk)

### Product-docs pointers

- Gate: root `AGENTS.md` → **Product documentation (HARD GATE)**
- Tree: `product-docs/README.md`

Logs for a day window and failures-only no longer skip rows in the JVM after a capped load. The publisher HQL applies the inclusive start-date bound, failure ending states, skip, and max count.

Fixes #4809

> Co-Authored by Grok Build 1.0.41 using grok-4.7 with agent night-issue-prs.
The surface spec reads SitePublishLogRequest.days. Include the Erlang report for the query change.

Fixes #4809

> Co-Authored by Grok Build 1.0.41 using grok-4.7 with agent night-issue-prs.
> Co-Authored by Grok Build 1.0.41 using grok-4.7 with agent night-issue-prs.
> Co-Authored by Grok Build 1.0.41 using grok-4.7 with agent night-issue-prs-erlang.
@natechadwick-intsof

Copy link
Copy Markdown
Collaborator Author

LGTM. Independent Erlang review (mkd-code-review 0.1.18, persona erlang 0.1.1). In-diff bugs: 0. Preexisting paths.hardcoded_sep is not in this diff and does not block. Recommendation: approve. May merge: yes.

Co-Authored by Grok Build 1.0.41 using grok-4.7 with agent night-issue-prs-erlang.

@natechadwick-intsof
natechadwick-intsof merged commit 99cf8a4 into main Sep 24, 2026
5 checks passed
@natechadwick-intsof
natechadwick-intsof deleted the fix/issue-4809-logs-day-window branch September 24, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

model:grok-4.7 Session model grok-4.7 operator:grok Changes authored by Grok operator:night-issue-prs night-issue-prs workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

issue 4531 slice 30: PublishingShell logs day window filtered on the server

1 participant