Repository navigation
fix(publish): filter Publishing logs day window on the server - #4823
Merged
Merged
Conversation
Logs for a day window and failures-only no longer skip rows in the JVM after a capped load. The publisher HQL applies the inclusive start-date bound, failure ending states, skip, and max count. Fixes #4809 > Co-Authored by Grok Build 1.0.41 using grok-4.7 with agent night-issue-prs.
The surface spec reads SitePublishLogRequest.days. Include the Erlang report for the query change. Fixes #4809 > Co-Authored by Grok Build 1.0.41 using grok-4.7 with agent night-issue-prs.
> Co-Authored by Grok Build 1.0.41 using grok-4.7 with agent night-issue-prs.
> Co-Authored by Grok Build 1.0.41 using grok-4.7 with agent night-issue-prs-erlang.
Collaborator
Author
|
LGTM. Independent Erlang review (mkd-code-review 0.1.18, persona erlang 0.1.1). In-diff bugs: 0. Preexisting paths.hardcoded_sep is not in this diff and does not block. Recommendation: approve. May merge: yes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parent: #4531. Slice: #4809.
Publishing Logs no longer skips a day window or failures-only rows in the JVM after a capped load.
PSSitePublishStatusService.buildLogspasses days, max count, skip, and failures-only intoIPSPublisherService. The HQL adds an inclusivestartDate >= :fromDatebound (days == -1omits it) and, when failures-only,endingStatus inaborted, canceled, completed-with-failures, and restart-needed. Skip and max are HibernatefirstResult/maxResults.Existing 4-arg
*WithFiltersmethods still delegate with skip 0 and failures-only false (current-job lookback unchanged).Operator: Grok: night-issue-prs (model grok-4.7)
Fixes #4809
Test plan
cd system && JAVA_HOME=JDK21 ../mvnw clean install— BUILD SUCCESS, Tests run: 3101, Failures: 0 (includesPSPubStatusLogQueryTest4 tests).cd projects/sitemanage && ../../mvnw clean install— BUILD SUCCESS, Tests run: 3068, Failures: 0 (includesPSSitePublishLogWindowTest).python3 docker/scripts/perc-devctl.py qa-up→TEST_CMS_URL=http://127.0.0.1:9993→qa-deploy-war-jars --restart-jetty→qa-healthRESULT:OK HEALTH:healthy HTTP:200.npm run test:surface -- --path tests/publishing/logsDayWindow.spec.js— 1 passed. Console errors asserted empty.server.logtail had no ERROR/FATAL.Checklist
product-docs/8.2/admin/publishing.md(Logs day window and failures-only are server query predicates).PSPubStatusLogQueryTest,PSSitePublishLogWindowTest; system and sitemanage standalone clean install green.modules/perc-qa-automation/frontend/tests/publishing/logsDayWindow.spec.js(posts days 3 and showOnlyFailures onSitePublishLogRequest). No WebUI source change; the days control already existed.clean install(no skipTests). New publisher overloads; grep found no otherimplements IPSPublisherService. sitemanage clean install is the reverse-dep compile.Pre-push local code review
Summary
Machine analysis found 1 finding(s), 0 bug(s).
Scope
Recommendation
approve
Gate
Issues
Issue 1 -- Severity: bug
paths.hardcoded_seppaths.hardcoded_sepSummary
Machine analysis found 1 finding(s), 0 bug(s). LLM skipped (machine_only_mode)
Scope
Recommendation
approve
Gate
Issues
Issue 1 -- Severity: bug
paths.hardcoded_seppaths.hardcoded_sep