Skip to content

feat(publishing): incremental queue item list (#4787) - #4794

Merged
natechadwick-intsof merged 3 commits into
mainfrom
fix/issue-4787-incremental-queue-list
Sep 23, 2026
Merged

natechadwick-intsof merged 3 commits into
mainfrom
fix/issue-4787-incremental-queue-list

Conversation

@natechadwick-intsof

@natechadwick-intsof natechadwick-intsof commented Sep 23, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

PublishingShell Incremental preview lists queued items as rows (content id and title or name) instead of a count. An empty queue stays an empty state with no rows. A failed list request shows an error and does not invent rows.

Parent: #4531. Slice: #4787.

Operator: Grok: night-issue-prs (model grok-4.7)

Test plan

  • Vitest incrementalQueue id/label helpers and SiteWorkspace rows, empty state, and load failure
  • Playwright tests/publishing-incremental-queue-list.spec.js on H2 QA (3 passed): rows, empty, load failure; console-clean=yes on success paths
  • Human spot-check on a site that already has a real incremental queue (Playwright proved the list against a stubbed queue payload on a live H2 site workspace)

Product documentation

  • Updated product-docs/8.2/admin/publishing.md (incremental preview rows)

Maven / C3

modules_built: WebUI, modules/perc-qa-automation

downstream_checked: none (no public Java type or signature change)

JAVA_HOME=/usr/lib/jvm/java-21-openjdk
cd WebUI && rtk mvn clean install
# BUILD SUCCESS
# Tests run: 69, Failures: 0, Errors: 0, Skipped: 0
# vitest: Test Files 533 passed; Tests 4901 passed

cd modules/perc-qa-automation && rtk mvn clean install
# BUILD SUCCESS
# No tests to run (Playwright is opt-in; surface spec run separately)

C5 UI proof

python3 docker/scripts/perc-devctl.py qa-up
# RESULT:OK TEST_CMS_URL=http://127.0.0.1:9993 QA_CONTAINER=perc-matrix-cms-h2
python3 docker/scripts/perc-devctl.py qa-health
# RESULT:OK HTTP:200 HEALTH:healthy
python3 docker/scripts/perc-devctl.py qa-deploy-webui
python3 docker/scripts/perc-devctl.py qa-health
# RESULT:OK HTTP:200 HEALTH:healthy
cd modules/perc-qa-automation/frontend
TEST_CMS_URL=http://127.0.0.1:9993 ADMIN_USERNAME=Admin TEST_DB_TYPE=h2 TEST_PRODUCT=cms \
  npm run test:surface -- --path tests/publishing-incremental-queue-list.spec.js
# 3 passed
# console-clean=yes (success and empty specs; failure spec expects the visible error)
# server.log-clean=yes (no ERROR/FATAL in the tail of jetty server.log for the window)
python3 docker/scripts/perc-devctl.py qa-down

Fixes #4787

Pre-push local code review

Summary

Machine analysis found 0 finding(s), 0 bug(s).

Scope

  • Base: origin/main
  • Head: HEAD
  • Files: 8 analyzed
  • Persona: erlang 0.1.1
  • Persona source: /home/nate/.local/share/mkd/agents/erlang

Recommendation

approve

Gate

  • Blocking bugs: 0
  • May commit/push: yes

Issues

No issues.

Co-Authored by Grok Build 1.0.41 using grok-4.7 with agent night-issue-prs-erlang.

Show content id and title or name for each queued item on Incremental preview, keep an empty state when the queue is empty, and surface load failures. Issue #4787.

> Co-Authored by Grok Build 1.0.41 using grok-4.7 with agent night-issue-prs.
@natechadwick-intsof natechadwick-intsof added operator:grok Changes authored by Grok operator:night-issue-prs night-issue-prs workflow model:grok-4.7 Session model grok-4.7 labels Sep 23, 2026
> Co-Authored by Grok Build 1.0.41 using grok-4.7 with agent night-issue-prs.
> Co-Authored by Grok Build 1.0.41 using grok-4.7 with agent night-issue-prs-erlang.
@natechadwick-intsof

Copy link
Copy Markdown
Collaborator Author

Erlang review (independent)

LGTM. mkd-code-review 0.1.18 pack percussion, gate advisory, base origin/main, head 08c19724ad. Persona erlang 0.1.1. 0 bugs. Behavioral Vitest covers id/label rows, empty queue, and load failure; Playwright surface covers the same three states. Product-docs incremental preview rows updated. No rule diffs. Report: docs/ai-generated/code-reviews/pr-4794-erlang.md.

Same-login GitHub APPROVE is not available; this comment is the LGTM.

Co-Authored by Grok Build 1.0.41 using grok-4.7 with agent night-issue-prs-erlang.

@natechadwick-intsof
natechadwick-intsof merged commit d2c6274 into main Sep 23, 2026
8 checks passed
@natechadwick-intsof
natechadwick-intsof deleted the fix/issue-4787-incremental-queue-list branch September 23, 2026 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

model:grok-4.7 Session model grok-4.7 operator:grok Changes authored by Grok operator:night-issue-prs night-issue-prs workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

issue 4531 slice 25: PublishingShell incremental queue item list

1 participant