Repository navigation
feat(explorer): session display-format columns (#4722) - #4743
Merged
Merged
Conversation
Operators can change Explorer folder-list columns without rewriting the shared display format. PUT/GET /explorer/list-columns keeps the overlay for the user and folder in server memory, maps a missing user to 403, and rejects unknown sources with 400. > Co-Authored by Grok Build 1.0.40 using grok-4.6 with agent night-issue-prs.
Record the pre-push mkd-code-review advisory report. In-diff bugs: 0. > Co-Authored by Grok Build 1.0.40 using grok-4.6 with agent night-issue-prs-erlang.
Collaborator
Author
|
LGTM. Erlang 0.1.1 / mkd-code-review 0.1.18 (pack percussion, gate advisory, base origin/main). In-diff findings: 0. Preexisting rows are outside the diff and do not block. Tests cover the new 400/403 (and 404 on #4744) paths. Same-login APPROVE is rejected by GitHub; this comment is the review.
|
natechadwick-intsof
deleted the
fix/issue-4722-explorer-list-columns
branch
September 22, 2026 21:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Slice 20 of #4530. Operators change columns on the current Explorer folder list without editing the shared display format.
GET/PUT /Rhythmyx/services/explorer/list-columnsstores the overlay in server memory for that user and folder (sys_titlerequired). Unknown or duplicate sources and a bad path are HTTP 400. No request user is HTTP 403.Parent: #4530. Fixes #4722.
Operator: Grok: night-issue-prs (model grok-4.6)
Test plan
ExplorerListColumnsResourceTest(save/get, other user, 400, 403)listColumnsApi.test.tstests/explorer-list-columns.spec.json H2 (3 passed)Product documentation
product-docs/8.2/admin/content-explorer.md(Columns control, 400/403, session scope)Pre-PR Maven
cd rest && bash ../mvnw clean install— BUILD SUCCESS. Tests run: 1547, Failures: 0cd projects/sitemanage && bash ../../mvnw clean install— BUILD SUCCESS. Tests run: 2966, Failures: 0, Skipped: 125cd WebUI && bash ../mvnw clean install— BUILD SUCCESS. Tests run: 69, Failures: 0sitemanage-beans.xmland locked byCatalogRestJaxrsRegistrationTest.UI proof (H2)
python3 docker/scripts/perc-devctl.py qa-up— TEST_CMS_URL=http://127.0.0.1:9993, container perc-matrix-cms-h2qa-healthRESULT:OK HEALTH:healthyqa-deploy-war-jars --restart-jettyplusdocker cpofsitemanage-beans.xml(CXF service bean) andqa-deploy-webuiqa-healthagain RESULT:OKrtk npm run test:surface -- --path tests/explorer-list-columns.spec.js— 3 passedqa-downremoved perc-matrix-cms-h2Pre-push local code review
Erlang review — PR #4743
Scope
CLI stdout (
mkd-code-review analyze --format markdown)Summary
Machine analysis found 15 finding(s), 0 bug(s).
Scope
Recommendation
approve
Gate
Issues
Issue 1 -- Severity: bug
secrets.heuristicsecrets.heuristicIssue 2 -- Severity: bug
paths.hardcoded_seppaths.hardcoded_sepIssue 3 -- Severity: bug
paths.hardcoded_seppaths.hardcoded_sepIssue 4 -- Severity: bug
paths.hardcoded_seppaths.hardcoded_sepIssue 5 -- Severity: bug
paths.hardcoded_seppaths.hardcoded_sepIssue 6 -- Severity: bug
paths.hardcoded_seppaths.hardcoded_sepIssue 7 -- Severity: bug
paths.hardcoded_seppaths.hardcoded_sepIssue 8 -- Severity: bug
paths.hardcoded_seppaths.hardcoded_sepIssue 9 -- Severity: bug
paths.hardcoded_seppaths.hardcoded_sepIssue 10 -- Severity: bug
paths.hardcoded_seppaths.hardcoded_sepIssue 11 -- Severity: bug
paths.hardcoded_seppaths.hardcoded_sepIssue 12 -- Severity: bug
paths.hardcoded_seppaths.hardcoded_sepIssue 13 -- Severity: bug
paths.hardcoded_seppaths.hardcoded_sepIssue 14 -- Severity: bug
paths.hardcoded_seppaths.hardcoded_sepIssue 15 -- Severity: bug
paths.hardcoded_seppaths.hardcoded_sep