Repository navigation
feat(publish): PublishingShell logs search and filter (#4616) - #4650
Conversation
natechadwick-intsof
left a comment
There was a problem hiding this comment.
Erlang (spawned sub-agent) — PR #4650 / #4616
Recommendation: LGTM (COMMENT only — this is own-model; no APPROVE).
Gate: May merge from Erlang perspective: yes (peer/human still required).
Scope
PublishingShell Logs client search/status filter, server showOnlyFailures checkbox, Vitest, Playwright surface, product-docs 8.2 admin publishing.
Hard gates
- Bugs: none found. Filter helpers are conservative (
fail/error/abortedvssuccess/complete/ok); haystack includes site/server/job/status/date. Failures-only is applied on Apply viabuildLogRequest(server flag), not silently ignored. - Behavioral tests:
logsFilter.test.ts(query+status),LogsSection.filter.test.tsx(UI), Playwrightpublishing-logs-filter.spec.js+ unit helpers. Change-class companions present (WebUI + perc-qa-automation + product-docs). - Paths: no filesystem I/O.
- Copyright: new files use Intersoft 2026 headers.
Memory patterns hit: change-class closure (Playwright + product-docs for WebUI screen).
Co-Authored by Grok Build 1.0.34 using grok-4.6 with agent night-issue-prs-erlang.
Erlang (spawned sub-agent) — PR #4650 / #4616Recommendation: LGTM (COMMENT only — this is own-model; no APPROVE). ScopePublishingShell Logs client search/status filter, server Hard gates
Memory patterns hit: change-class closure (Playwright + product-docs for WebUI screen).
|
Summary
PublishingShell Logs now lets operators search and filter historical publish jobs by site (existing), status, and free text, plus a Failures only (server) checkbox that sets
showOnlyFailuresonPOST …/sitemanage/pubstatus/logs. REST already existed; this slice is SPA + tests + product-docs.Parent tracker: #4531
Fixes #4616
Operator: Grok: night-issue-prs (model grok-4.6)
Test plan
cd WebUI && ../mvnw clean install— BUILD SUCCESS; Vitest 4600 passed; Surefire 69 passed.cd modules/perc-qa-automation && ../../mvnw clean install— BUILD SUCCESS.npm run test:unitin perc-qa-automation/frontend — helper tests includingpublishing-logs-filter.test.js.python docker/scripts/perc-devctl.py qa-up→qa-healthRESULT:OK; hot-copycm/modernassets intoperc-matrix-cms-h2; Jetty Stop/Start inside cell;qa-healthagain.npm run test:surface -- --path tests/publishing-logs-filter.spec.jswithTEST_CMS_URLfrom qa-up — 1 passed; console-clean=yes.Checklist
product-docs/8.2/admin/publishing.md(Search and filter publish logs)logsFilter.test.ts,LogsSection.filter.test.tsx, QA helper unit teststests/publishing-logs-filter.spec.js/only)C3 evidence
WebUI,modules/perc-qa-automationcd WebUI && ../mvnw clean installBUILD SUCCESS (Surefire Tests run: 69, Failures: 0; Vitest Tests 4600 passed).cd modules/perc-qa-automation && ../../mvnw clean installBUILD SUCCESS (No tests to run in Surefire; frontend unit tests 558 pass including logs-filter helpers).C5 UI proof
TEST_CMS_URL=http://127.0.0.1:9993containerperc-matrix-cms-h2generated-webui/cm/modern→/opt/Percussion/jetty/base/webapps/Rhythmyx/cm/modern/; StopJetty/StartJetty inside cell; qa-health RESULT:OKnpm run test:surface -- --path tests/publishing-logs-filter.spec.js— 1 passed (2.4s)Erlang (spawned grok agent): approve —
docs/ai-generated/code-reviews/issue-4616-publishing-logs-filter-erlang.md