Skip to content

issue 1690 slice 1: item-filter rules write (AS-07) #4438

Description

@natechadwick-intsof

Parent

Parent: #1690

Workbench inventory P1 (AS-07). Filter create/save/delete already ships on origin/main. Remaining: operators can write rule rows in Developer chrome (today the rules table is read-only and Save only round-trips loaded rules).

Slice goal

One user-visible increment: An Admin can add, edit, and remove item-filter rules (name + params) on Developer → Item Filters detail, persist via existing Admin PUT /services/itemfilters/{idOrName} (rules[]), see the catalog GET round-trip, and follow product-docs.

HARD BAN: do not split REST vs SPA vs Playwright. Do not invent a new SOAP surface. Do not stack with #4434 product-docs XSL (different parent; avoid admin/index.md thrash if that PR is open — prefer in-page links).

In scope

  1. SPA: rule editor on ItemFilterDetailPanel (add/edit/remove rows; params name/value). Create may send rules[]; PUT omitted rules stays unchanged; rules: [] clears.
  2. REST/adaptor only if the existing PUT contract is insufficient (unit tests on exact production types). Prefer using shipped ItemFilter.rules.
  3. Surface-filtered Playwright (QA H2: perc-devctl qa-up → qa-health → TEST_CMS_URL → npm run test:surface path/grep/tag → qa-down). Do not HTTP-poll /Rhythmyx/login after a failed Jetty start.
  4. Update product-docs/8.2/admin/developer-item-filters.md and product-docs/8.2/developer/rest.md Item filters section. Keep frontmatter id: stable.

Out of scope

  • Shared field nested field editor (slice 2)
  • System-def control properties (slice 3)
  • Pipeline graph editor / mapper persist
  • 100% classic Workbench visual metaphor

Acceptance

  • Admin can add/edit/delete at least one rule (with params) in Developer Item Filters; GET shows it; clear via rules: [] or UI
  • Non-Admin 403; invalid rule name 400; unknown filter 404
  • Playwright surface spec green on QA H2; console-clean; server.log-clean
  • Product-docs match shipped behavior; [8.2] Developer module — post-P0 follow-ons #1690 Agent progress updated

Modules

rest (only if contract gap), projects/sitemanage (only if adaptor gap), WebUI, modules/perc-qa-automation, product-docs/8.2/

Leave unassigned. Do not add In Progress.

Co-Authored by Grok Build 1.0.24 using grok-4.6 with agent night-issue-prs-triage.

Activity

  1. added
    enhancementNew feature or request
    8.2This issue found in 8.2 release
    p2Priority 2 (p1 highest, p8 lowest)
    in progressAgent or human actively working
    on Sep 9, 2026
  2. natechadwick-intsof commented on Sep 9, 2026

    @natechadwick-intsof
    CollaboratorAuthor

    night-issue-prs: starting work on item-filter rules write (AS-07).

    Co-Authored by Grok Build 1.0.24 using grok-4.5 with agent night-issue-prs.

  3. natechadwick-intsof commented on Sep 9, 2026

    @natechadwick-intsof
    CollaboratorAuthor

    Mitigation / delivery: PR #4441 (commit 86e7cc7cad). Item Filters detail rule editor; PUT rules[] + clearRules; Playwright 3/3.

    Co-Authored by Grok Build 1.0.24 using grok-4.5 with agent night-issue-prs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    8.2This issue found in 8.2 releaseenhancementNew feature or requestmodel:grok-4.6Session model grok-4.6operator:grokChanges authored by Grokoperator:night-issue-prsnight-issue-prs workflowp2Priority 2 (p1 highest, p8 lowest)

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions