Repository navigation
issue 1788 slice 2: SolrJ 10 compile cutover + unit tests (system/metadata primary) #1997
Copy link
Copy link
Closed
Labels
8.2This issue found in 8.2 releaseThis issue found in 8.2 releasedependenciesPull requests that update a dependency filePull requests that update a dependency fileenhancementNew feature or requestNew feature or requestjavaPull requests that update java codePull requests that update java codemodel:grok-4.5Grok 4.5 modelGrok 4.5 modeloperator:grokChanges authored by GrokChanges authored by Grokoperator:night-issue-prsnight-issue-prs workflownight-issue-prs workflowtech-debttech debttech debt
Description
Parent
Part of #1788. Depends on inventory from #1996 (slice 1).
Goal
On a feature branch from main, bump SolrJ to 10.x only as part of real code refactor (not Dependabot-only), fix compile breaks in system (and WebUI if needed), and add unit tests around client construction / error handling. Do not merge a bare solr.version edit.
Scope
- Branch from
main(e.g.fix/issue-1788-solrj-10-cutover). - Set root
solr.versionto current 10.x patch (or 10.0.0+) with accompanying Java changes. - Refactor
PSSolrDeliveryHandler#getClient:- Replace removed
HttpSolrClient(HttpClient-based) with SolrJ 10 supported client (JDK and/orsolr-solrj-jettyas inventory directs). - Preserve multipart / extract upload behavior equivalent to
setUseMultiPartPost(true). - Revisit cloud path: ZK list vs Solr URLs; default collection on builder; document if cloud path remains supported given product POM excludes ZK today.
- Replace removed
- Fix any import/package moves (
SolrQuery, client packages, etc.). - Unit tests:
- Mock
SolrClientwhere practical for add/delete/commit paths. - Cover standalone vs cloud construction branches without a live Solr.
- Keep
SolrConfigLoaderTestgreen; expand as needed.
- Mock
- Per-module gates:
cd system && …/mvnw clean install(and WebUI if touched). Spotless apply then check. Erlang pre-commit on authored code.
Out of scope
- Full DTS live smoke (slice 4)
- Dependabot build(deps): bump org.apache.solr:solr-solrj from 9.10.1 to 10.0.0 #1777 close (slice 5)
- Live cluster credentials
- Java 8 line
Acceptance
-
system(and any other touched module) clean install green on JDK 21 - No HttpClient-based removed SolrClient APIs remain in product code
- Unit tests for construction / key update paths
- PR against
mainlinked from chore(deps): upgrade Apache Solr / SolrJ from 9.10.1 to 10.x (needs code refactor) #1788 (not a Dependabot-only diff)
Sequencing
After #1996. May land with or before packaging slice 3 if POM optional modules are required for compile.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
8.2This issue found in 8.2 releaseThis issue found in 8.2 releasedependenciesPull requests that update a dependency filePull requests that update a dependency fileenhancementNew feature or requestNew feature or requestjavaPull requests that update java codePull requests that update java codemodel:grok-4.5Grok 4.5 modelGrok 4.5 modeloperator:grokChanges authored by GrokChanges authored by Grokoperator:night-issue-prsnight-issue-prs workflownight-issue-prs workflowtech-debttech debttech debt
Activity
docs(1788): SolrJ call-site inventory vs Solr 10 (#1996) (#2002)
natechadwick-intsof commentedon Aug 5, 2026
Implemented in PR #2008 (branch
fix/issue-1997-solrj-10-cutover, commit36d8f24700). SolrJ 10.0.0 + HttpJdkSolrClient cutover + unit tests. Sibling packaging/verification remains #1998–#2000.fix(#1997): SolrJ 10 compile cutover with HttpJdkSolrClient + unit tests
fix(#1997): address PR #2008 review on PSSolrDeliveryHandler