Skip to content

issue 1788 slice 2: SolrJ 10 compile cutover + unit tests (system/metadata primary) #1997

Closed

Description

@natechadwick-intsof

Parent

Part of #1788. Depends on inventory from #1996 (slice 1).

Goal

On a feature branch from main, bump SolrJ to 10.x only as part of real code refactor (not Dependabot-only), fix compile breaks in system (and WebUI if needed), and add unit tests around client construction / error handling. Do not merge a bare solr.version edit.

Scope

  1. Branch from main (e.g. fix/issue-1788-solrj-10-cutover).
  2. Set root solr.version to current 10.x patch (or 10.0.0+) with accompanying Java changes.
  3. Refactor PSSolrDeliveryHandler#getClient:
    • Replace removed HttpSolrClient (HttpClient-based) with SolrJ 10 supported client (JDK and/or solr-solrj-jetty as inventory directs).
    • Preserve multipart / extract upload behavior equivalent to setUseMultiPartPost(true).
    • Revisit cloud path: ZK list vs Solr URLs; default collection on builder; document if cloud path remains supported given product POM excludes ZK today.
  4. Fix any import/package moves (SolrQuery, client packages, etc.).
  5. Unit tests:
    • Mock SolrClient where practical for add/delete/commit paths.
    • Cover standalone vs cloud construction branches without a live Solr.
    • Keep SolrConfigLoaderTest green; expand as needed.
  6. Per-module gates: cd system && …/mvnw clean install (and WebUI if touched). Spotless apply then check. Erlang pre-commit on authored code.

Out of scope

Acceptance

Sequencing

After #1996. May land with or before packaging slice 3 if POM optional modules are required for compile.

Activity

  1. natechadwick-intsof commented on Aug 5, 2026

    @natechadwick-intsof
    CollaboratorAuthor

    Implemented in PR #2008 (branch fix/issue-1997-solrj-10-cutover, commit 36d8f24700). SolrJ 10.0.0 + HttpJdkSolrClient cutover + unit tests. Sibling packaging/verification remains #1998–#2000.

  2. added a commit that references this issue on Aug 5, 2026
  3. added a commit that references this issue on Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    8.2This issue found in 8.2 releasedependenciesPull requests that update a dependency fileenhancementNew feature or requestjavaPull requests that update java codemodel:grok-4.5Grok 4.5 modeloperator:grokChanges authored by Grokoperator:night-issue-prsnight-issue-prs workflowtech-debttech debt

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions