sitemanage: fix 3 failing unit tests (PSItemServiceTest, PSDispatchingPathServicePathParsingTest)

[natechadwick-intsof]

Summary

Three unit tests in projects/sitemanage fail when the module's full surefire run executes. They pass in isolation but fail when the test JVM has prior state from earlier test classes.

Failing tests

1. PSItemServiceTest.setUp:102 — IllegalArgumentException: Cannot set rxDir system property rxdeploydir value /home/nate/.../tmp/junit<id> does not exist
2. PSDispatchingPathServicePathParsingTest.shouldFailOnNormalizeNullPath — expected<IllegalArgumentException> but was<NullPointerException>
3. PSDispatchingPathServicePathParsingTest.shouldFailToReturnProperFullPathIfGivenRelativePathIsNull — expected<IllegalArgumentException> but was<NullPointerException>

Root cause

• Tests perc_decoration.css !important fixed grid breaks responsive themes in editor/preview (8.1.7) #2 and Improve logging when DTS rotateKey push fails (HTTP 405 / security key) #3: PSDispatchingPathService$PathNormalizer.normalizePath and PSDispatchingPathService$PathMatch.toFullPath validate their input with org.apache.commons.lang3.Validate.notNull(...), which throws NullPointerException. The IPSPathNormalizer interface explicitly declares throws IllegalArgumentException, and the tests expect that exception.
• Test Support IMDSv2 for EC2 detection (Amazon Linux 2023+ S3 / Assume Role) #1: PSItemService's constructor calls PathUtils.getRxDir(null), which reads the rxdeploydir system property. Earlier test classes in the surefire JVM set this property to a JUnit TemporaryFolder root; once that test class finishes, the temp folder is deleted but the property remains, so the next class to load PathUtils.getRxDir blows up. PSItemServiceTest itself never established a valid rxdeploydir.

Fix

• PSDispatchingPathService: replace notNull(...) guards in PathNormalizer.normalizePath and PathMatch.toFullPath with explicit if (... == null) throw new IllegalArgumentException(...) checks so the contract matches the IPSPathNormalizer interface and the test expectations.
• PSItemServiceTest: add a @Rule TemporaryFolder and, in setUp / tearDown, use PathUtils.setThreadOnlyRxDir / unsetThreadOnlyRxDir plus PathUtils.clearRxDir() (the same pattern already used by PSEnsureMyFacesSecretTest in the same module) to isolate the test from rxdeploydir state left by other test classes.

Verification

[INFO] Tests run: 314, Failures: 0, Errors: 0, Skipped: 17
[INFO] BUILD SUCCESS

The 17 skipped tests are the pre-existing @Ignored tests, unchanged.