Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add quote to cart in case no cart exists #952

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

SGrueber
Copy link
Collaborator

@SGrueber SGrueber commented Dec 8, 2021

PR Type

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the Current Behavior?

If the user has no cart and he tries to add a quote to cart he gets only a cart-not-found-error message.

Issue Number: Closes #947

What Is the New Behavior?

If the user has no cart a new cart will be automatically created before the quote is added to cart.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

@SGrueber SGrueber self-assigned this Dec 8, 2021
@SGrueber SGrueber added this to the 2.0 milestone Dec 8, 2021
@MaxKless MaxKless self-requested a review December 16, 2021 09:05
Copy link
Collaborator

@MaxKless MaxKless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SGrueber SGrueber merged commit 114c8d5 into develop Dec 16, 2021
@SGrueber SGrueber deleted the bugfix/add_quote_to_cart branch December 16, 2021 11:27
SGrueber added a commit that referenced this pull request May 19, 2022
SGrueber pushed a commit that referenced this pull request May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add quote to cart doesn't work if the user has no cart yet
2 participants