Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: respect ICM setting "Add Product Behavior" when adding basket items #905

Merged
merged 1 commit into from
Oct 11, 2021
Merged

fix: respect ICM setting "Add Product Behavior" when adding basket items #905

merged 1 commit into from
Oct 11, 2021

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Oct 11, 2021 •
edited
Loading

PR Type

[x] Bugfix

What Is the Current Behavior?

The ICM Application setting Shopping Cart & Checkout > Add Product Behavior is not properly respected by the PWA

Steps to repeat:
BO:

  • go to ICM BO
  • manage B2B channel
  • 'Applications' > select 'Progressive Web App' application
  • tab 'Shopping Cart & Checkout' change 'Add Product Behavior' to 'Allow Repeats'

PWA:

  • go to quickorder
  • add multiple entries for one product
  • add to cart

Expected:

  • multiple entries in cart

Actual:

  • one line item with quantities merged

What Is the New Behavior?

  • disabled the quantity merging in the PWA and let ICM handle it automatically

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

AB#70421

@dhhyi dhhyi added the bug Something isn't working label Oct 11, 2021
@dhhyi dhhyi requested a review from SGrueber October 11, 2021 10:18
@shauke shauke added this to the 1.3 milestone Oct 11, 2021
@SGrueber SGrueber merged commit a5fd804 into develop Oct 11, 2021
@SGrueber SGrueber deleted the fix/respect-basket-add-product-behavior branch October 11, 2021 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SGrueber SGrueber SGrueber approved these changes

Assignees

@SGrueber SGrueber

Labels
bug Something isn't working
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@dhhyi @SGrueber @shauke