Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: forward mouse event to callback handler in server-html directive #750

Merged
merged 1 commit into from
Jun 29, 2021
Merged

feat: forward mouse event to callback handler in server-html directive #750

merged 1 commit into from
Jun 29, 2021

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Jun 28, 2021

PR Type

[x] Feature

What Is the Current Behavior?

Callback handlers in ServerHtmlDirective don't see the MouseEvent and can not do something like event.preventDefault().

What Is the New Behavior?

The MouseEvent is forwarded to the callback handler as an optional argument.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

@dhhyi dhhyi added the enhancement Enhancement to an existing feature label Jun 28, 2021
@dhhyi dhhyi requested a review from shauke June 28, 2021 12:01
@dhhyi dhhyi marked this pull request as ready for review June 28, 2021 12:02
@shauke shauke self-assigned this Jun 28, 2021
@shauke shauke added this to the 0.32 milestone Jun 28, 2021
@shauke shauke merged commit 478c096 into develop Jun 29, 2021
@shauke shauke deleted the feat/forward-mouse-event branch June 29, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shauke shauke shauke approved these changes

Assignees

@shauke shauke

Labels
enhancement Enhancement to an existing feature
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dhhyi @shauke