Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support multiple themes #64

Merged
merged 5 commits into from
Jan 17, 2020
Merged

feat: support multiple themes #64

merged 5 commits into from
Jan 17, 2020

Conversation

Sebastian-Haehnlein
Copy link
Contributor

@Sebastian-Haehnlein Sebastian-Haehnlein commented Dec 16, 2019 •
edited
Loading

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • CI-related changes
  • Documentation content changes
  • application / infrastructure changes
  • Other... Please describe:

What Is the Current Behavior?

Issue Number:
#49

What Is the New Behavior?

multiple styles & matrix-parameter switch

Does this PR Introduce a Breaking Change?

  • Yes
  • No

@Sebastian-Haehnlein Sebastian-Haehnlein self-assigned this Dec 16, 2019
@Sebastian-Haehnlein Sebastian-Haehnlein force-pushed the explore/multi-theme branch 6 times, most recently from 07aab09 to 816b679 Compare December 17, 2019 08:40
dhhyi
dhhyi requested changes Dec 17, 2019
View reviewed changes
Copy link
Collaborator

@dhhyi dhhyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add it to the nginx configuration, so the theme can be set for each channel

angular.json Outdated Show resolved Hide resolved
src/environments/environment.model.ts Outdated Show resolved Hide resolved
src/app/core/store/configuration/configuration.effects.ts Outdated Show resolved Hide resolved
src/app/core/facades/theme.facade.ts Outdated Show resolved Hide resolved
src/app/core/facades/theme.facade.ts Outdated Show resolved Hide resolved
src/app/core/facades/theme.facade.ts Outdated Show resolved Hide resolved
src/app/app.component.ts Outdated Show resolved Hide resolved
src/app/core/facades/theme.facade.ts Outdated Show resolved Hide resolved
@shauke shauke added the feature New feature or request label Dec 17, 2019
@shauke shauke added this to the 0.17 milestone Dec 17, 2019
@shauke shauke self-requested a review December 17, 2019 15:36
dhhyi
dhhyi requested changes Dec 19, 2019
View reviewed changes
.gitlab-ci.yml Outdated Show resolved Hide resolved
dhhyi
dhhyi previously approved these changes Dec 19, 2019
View reviewed changes
@dhhyi dhhyi changed the title Explore/multi theme feat: support multiple themes Dec 19, 2019
@dhhyi dhhyi self-requested a review January 9, 2020 13:53
dhhyi
dhhyi requested changes Jan 9, 2020
View reviewed changes
src/app/app.component.spec.ts Outdated Show resolved Hide resolved
src/environments/environment.model.ts Outdated Show resolved Hide resolved
@Sebastian-Haehnlein Sebastian-Haehnlein force-pushed the explore/multi-theme branch 3 times, most recently from edce062 to 613f268 Compare January 10, 2020 08:50
dhhyi
dhhyi previously approved these changes Jan 10, 2020
View reviewed changes
@dhhyi dhhyi mentioned this pull request Jan 11, 2020
Merged
2 tasks
shauke
shauke previously approved these changes Jan 14, 2020
View reviewed changes
Copy link
Collaborator

@shauke shauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All is fine now.
We still need to wait for the definition of the new B2B color and the fitting logo images.

@shauke shauke added the wait Waiting for something (e.g. new ICM release) label Jan 14, 2020
@dhhyi
Copy link
Collaborator

dhhyi commented Jan 14, 2020

We still need to wait for the definition of the new B2B color and the fitting logo images.

Might I suggest doing that later in another PR? There is plenty of business value already packed in here, we can release it for projects to use and also provide schematics creating a new theme here. (see #77)

@shauke shauke removed the wait Waiting for something (e.g. new ICM release) label Jan 16, 2020
@shauke shauke merged commit a5f49fb into develop Jan 17, 2020
@shauke shauke deleted the explore/multi-theme branch January 17, 2020 07:55
shauke pushed a commit that referenced this pull request Jan 17, 2020
@Sebastian-Haehnlein @shauke
feat: support for multiple themes and switching via environment (#49, #…
9f53006 
…64)
shauke pushed a commit that referenced this pull request Jan 17, 2020
@Sebastian-Haehnlein @shauke
feat: styling restructuring for multiple themes support and introduct…
fb62ebb 
…ion of an alternative blue theme (#49, #64)

- rename the styling root 'theme' folder to 'styles'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shauke shauke shauke approved these changes

@dhhyi dhhyi dhhyi left review comments

Assignees

@Sebastian-Haehnlein Sebastian-Haehnlein

Labels
feature New feature or request
Projects
None yet
Milestone
0.17
Development

Successfully merging this pull request may close these issues.
3 participants
@Sebastian-Haehnlein @dhhyi @shauke