Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adapt nginx Dockerfile to nginx-prometheus-exporter changes (#632) #633

Merged
merged 1 commit into from
Mar 24, 2021
Merged

fix: adapt nginx Dockerfile to nginx-prometheus-exporter changes (#632) #633

merged 1 commit into from
Mar 24, 2021

Conversation

shauke
Copy link
Collaborator

@shauke shauke commented Mar 23, 2021

PR Type

[x] Bugfix

What Is the Current Behavior?

Running docker build -t nginx nginx currently results in an error for the nginx/nginx-prometheus-exporter step.

Issue Number: Closes #632

What Is the New Behavior?

nginx docker build is working again.

Does this PR Introduce a Breaking Change?

[x] No

@shauke shauke added the bug Something isn't working label Mar 23, 2021
@shauke shauke added this to the 0.29 milestone Mar 23, 2021
@shauke shauke self-assigned this Mar 23, 2021
@shauke shauke requested a review from jometzner March 23, 2021 17:33
jometzner
jometzner suggested changes Mar 24, 2021
View reviewed changes
nginx/Dockerfile Outdated Show resolved Hide resolved
@shauke shauke force-pushed the bug/nginx-prometheus-exporter_adaption branch from f4f4558 to 51cd644 Compare March 24, 2021 09:41
@shauke shauke merged commit 496753c into develop Mar 24, 2021
@shauke shauke deleted the bug/nginx-prometheus-exporter_adaption branch March 24, 2021 11:12
shauke added a commit that referenced this pull request Mar 25, 2021
@shauke
fix: adapt nginx Dockerfile to nginx-prometheus-exporter changes and …
4a419e3 
…pinned version (#632, #633)

closes #632

(cherry picked from commit 496753c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jometzner jometzner jometzner requested changes

Assignees

@shauke shauke

Labels
bug Something isn't working
Projects
None yet
Milestone
0.29
Development

Successfully merging this pull request may close these issues.

[nginx] docker build failing for nginx/nginx-prometheus-exporter
2 participants
@shauke @jometzner