fix: unnecessary feature module load #631
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no API changes)
[x] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[x] Application / infrastructure changes
[x] Other: Performance Improvement
What Is the Current Behavior?
In version 0.28 of the PWA there are feature modules loaded even if the features are deactivated:
Go to https://intershoppwa.azurewebsites.net/home and open the 'Network' tab of the developer tools and filter for 'JS' files.
In this case the modules for
tacton
andpunchout
are loaded even if the features are not active. This also happens for thesentry
feature if run locally.What Is the New Behavior?
Only active feature modules are pulled. For local development with default settings:
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
tacton
andpunchout
was caused byProductContextDisplayPropertiesService
s, that were bundled in the feature module, but provided in the feature-export modules.sitekey-provider.service
to match this patternsentry
feature could be persuaded to load lazily againcore/extras.module.ts
as it was mainly undocumented and not used consistentlyAfter all reviewing and additional work, please squash-merge.