Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: repair add-destroy schematic #602

Merged
merged 1 commit into from
Mar 8, 2021
Merged

fix: repair add-destroy schematic #602

merged 1 commit into from
Mar 8, 2021

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Mar 6, 2021

PR Type

[x] Bugfix

What Is the Current Behavior?

  • add-destroy schematic broken since last release

What Is the New Behavior?

  • repaired
  • test added

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

@dhhyi dhhyi added the bug Something isn't working label Mar 6, 2021
@dhhyi dhhyi self-assigned this Mar 6, 2021
@dhhyi dhhyi marked this pull request as ready for review March 6, 2021 18:38
@dhhyi dhhyi removed their assignment Mar 6, 2021
@SGrueber SGrueber self-requested a review March 8, 2021 08:57
@SGrueber SGrueber self-assigned this Mar 8, 2021
@SGrueber SGrueber added this to the 0.29 milestone Mar 8, 2021
@SGrueber SGrueber merged commit bcc0401 into develop Mar 8, 2021
@SGrueber SGrueber deleted the fix/add-destroy branch March 8, 2021 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SGrueber SGrueber SGrueber approved these changes

Assignees

@SGrueber SGrueber

Labels
bug Something isn't working
Projects
None yet
Milestone
0.29
Development

Successfully merging this pull request may close these issues.
2 participants
@dhhyi @SGrueber