-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: error messages quote-edit #51
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SGrueber
previously approved these changes
Dec 12, 2019
shauke
force-pushed
the
bugfix/quote-edit-error-message
branch
from
December 12, 2019 15:29
5f74630
to
850b079
Compare
Sebastian-Haehnlein
force-pushed
the
bugfix/quote-edit-error-message
branch
from
January 6, 2020 10:56
850b079
to
e9c4abf
Compare
In regards to the original issue, there is still a lot to do:
And even the current fix itself only changed the format of the error message a bit but not in the requested way. Or was this discussed with IAD?
|
Sebastian-Haehnlein
force-pushed
the
bugfix/quote-edit-error-message
branch
3 times, most recently
from
February 7, 2020 08:06
c2f61e6
to
339900e
Compare
shauke
force-pushed
the
bugfix/quote-edit-error-message
branch
from
February 19, 2020 12:27
339900e
to
73e7b1f
Compare
shauke
commented
Feb 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All fine now.
shauke
pushed a commit
that referenced
this pull request
Feb 19, 2020
shauke
pushed a commit
that referenced
this pull request
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Is the Current Behavior?
Confusing error message is displayed: "400: Bad Request (Adding specified item finished with an error.)"
(Issue Number: ISREST-948)
What Is the New Behavior?
Steps to Repeat
Does this PR Introduce a Breaking Change?
[x] No