Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error messages quote-edit #51

Merged
merged 4 commits into from
Feb 19, 2020
Merged

fix: error messages quote-edit #51

merged 4 commits into from
Feb 19, 2020

Conversation

shauke
Copy link
Collaborator

@shauke shauke commented Dec 11, 2019 •
edited
Loading

What Is the Current Behavior?

Confusing error message is displayed: "400: Bad Request (Adding specified item finished with an error.)"

Out of Stock or Offline Product

(Issue Number: ISREST-948)

What Is the New Behavior?

  • Error message should display: The quote cannot be added to the shopping cart. It contains invalid products.
  • show Availability
  • remove "Add to Cart" button

IAD_offline_products

Steps to Repeat

  • Add product to quote request
  • Submit quote request
  • Submit quote via backoffice
  • Set product to out of stock or offline
  • View responded quote

Does this PR Introduce a Breaking Change?

[x] No

@SGrueber SGrueber self-requested a review December 12, 2019 08:36
SGrueber
SGrueber previously approved these changes Dec 12, 2019
View reviewed changes
@shauke shauke force-pushed the bugfix/quote-edit-error-message branch from 5f74630 to 850b079 Compare December 12, 2019 15:29
@Sebastian-Haehnlein Sebastian-Haehnlein self-assigned this Dec 18, 2019
@shauke shauke added this to the 0.17 milestone Jan 9, 2020
@shauke shauke added the bug Something isn't working label Jan 9, 2020
@shauke
Copy link
Collaborator Author

shauke commented Jan 9, 2020 •
edited
Loading

In regards to the original issue, there is still a lot to do:

  • remove "Add to Cart" button
  • show Availability

And even the current fix itself only changed the format of the error message a bit but not in the requested way. Or was this discussed with IAD?

  • Error message should display: "The quote cannot be added to the shopping cart. It contains invalid products."

@shauke shauke modified the milestones: 0.17, 0.18 Jan 21, 2020
@Sebastian-Haehnlein Sebastian-Haehnlein force-pushed the bugfix/quote-edit-error-message branch 3 times, most recently from c2f61e6 to 339900e Compare February 7, 2020 08:06
@shauke shauke force-pushed the bugfix/quote-edit-error-message branch from 339900e to 73e7b1f Compare February 19, 2020 12:27
shauke
shauke commented Feb 19, 2020
View reviewed changes
Copy link
Collaborator Author

@shauke shauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fine now.

@shauke shauke merged commit a70da64 into develop Feb 19, 2020
@shauke shauke deleted the bugfix/quote-edit-error-message branch February 19, 2020 12:53
shauke pushed a commit that referenced this pull request Feb 19, 2020
@Sebastian-Haehnlein @shauke
fix: display user friendly error messages for quoting (#51)
0c9a943
shauke pushed a commit that referenced this pull request Feb 19, 2020
@Sebastian-Haehnlein @shauke
fix: show quote item availability on quote detail page (#51)
788b6dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SGrueber SGrueber SGrueber left review comments

Assignees

@Sebastian-Haehnlein Sebastian-Haehnlein

Labels
bug Something isn't working
Projects
None yet
Milestone
0.18
Development

Successfully merging this pull request may close these issues.
3 participants
@shauke @SGrueber @Sebastian-Haehnlein