feat: enhance option to overwrite URL for ICM in express server #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhhyi
changed the title
rinkeshrsys
pushed a commit
to rinkeshrsys/intershop-pwa
that referenced
this pull request
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Feature
[x] Documentation content changes
[x] Application / infrastructure changes
What Is the Current Behavior?
PROXY_ICMis essentially a boolean flag and rewrites ICM URL depending on incoming request using protocol and host.What Is the New Behavior?
PROXY_ICMcan be set to URL replacing ICM location completely.Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No