fix: window object should only be used on browser side #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shauke
approved these changes
Jun 2, 2022
shauke
requested changes
Jun 2, 2022
src/app/extensions/tracking/store/tracking-config/tracking-config.effects.ts
Outdated
Show resolved
Hide resolved
shauke
force-pushed
the
fix/window-tracking-effect
branch
from
08fc327
to
cd4ddff
Compare
shauke
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Refactoring (no functional changes, no API changes)
What Is the Current Behavior?
If the tracking extension is enabled AND for some reason the cookies consent check is removed (project customization to use a different cookies consent management tool), then the tracking-config.effect.ts will use the window object on server side if a gtmToken is found.
What Is the New Behavior?
Making sure that the window object is only used on browser side independent from the potentially removed cookies consent handling.
Does this PR Introduce a Breaking Change?
[x] No
Other Information
AB#77211