feat(eslint): rule disallowing optional inputs #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhhyi
added
enhancement
MaxKless
approved these changes
Apr 21, 2022
paramaeder
pushed a commit
to paramaeder/intershop-pwa
that referenced
this pull request
May 11, 2022
SGrueber
pushed a commit
that referenced
this pull request
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Code style update (formatting, local variables)
What Is the Current Behavior?
Angular
@Inputdecorated fields are optional by default, so adding a?is confusing.What Is the New Behavior?
Added rule to remove the optional operator.
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
AB#76045