fix: hybrid approach adaptions #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shauke
added
bug
dhhyi
reviewed
Apr 5, 2022
shauke
force-pushed
the
feature/hybrid_approach_adaptions
branch
2 times, most recently
from
68ac574
to
c1e5252
Compare
shauke
force-pushed
the
feature/hybrid_approach_adaptions
branch
from
c1e5252
to
e003e7d
Compare
|
The redirect after checkout still works as expected. |
shauke
force-pushed
the
feature/hybrid_approach_adaptions
branch
from
e003e7d
to
14b411e
Compare
dhhyi
previously approved these changes
Apr 25, 2022
#1105) BREAKING CHANGES: For a working hybrid approach ICM 7.10.32.16-LTS or 7.10.38.6-LTS or newer is required. The changes in the PWA should not be incompatible with older ICM version if no hybrid approach is needed.
* required for hybrid approach otherwise SSR will return 404 for CSS and JS files
shauke
force-pushed
the
feature/hybrid_approach_adaptions
branch
from
14b411e
to
cfd9584
Compare
shauke
added a commit
that referenced
this pull request
Apr 29, 2022
#1105) BREAKING CHANGES: For a working hybrid approach ICM 7.10.32.16-LTS or 7.10.38.6-LTS or newer is required. The changes in the PWA should not be incompatible with older ICM version if no hybrid approach is needed.
shauke
added a commit
that referenced
this pull request
Apr 29, 2022
* required for hybrid approach otherwise SSR will return 404 for CSS and JS files
SGrueber
pushed a commit
that referenced
this pull request
May 19, 2022
#1105) BREAKING CHANGES: For a working hybrid approach ICM 7.10.32.16-LTS or 7.10.38.6-LTS or newer is required. The changes in the PWA should not be incompatible with older ICM version if no hybrid approach is needed.
SGrueber
pushed a commit
that referenced
this pull request
May 19, 2022
* required for hybrid approach otherwise SSR will return 404 for CSS and JS files
SGrueber
pushed a commit
that referenced
this pull request
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
[x] Refactoring (no functional changes, no API changes)
What Is the Current Behavior?
Hybrid approach did not work for anonymous users (missing functionality on ICM side).
What Is the New Behavior?
apiTokencookie handling after ICM adaptions (ICM version ???) for anonymous basketsDoes this PR Introduce a Breaking Change?
[x] No
Other Information
Needs ICM 7.10.38.6-LTS or 7.10.32.16-LTS or newer.
AB#75730