Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce price update strategies #1089

Merged
merged 1 commit into from
May 3, 2022
Merged

feat: introduce price update strategies #1089

merged 1 commit into from
May 3, 2022

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Mar 29, 2022 •
edited by azure-boards bot
Loading

PR Type

[x] Feature
[x] Refactoring (no functional changes, no API changes)

What Is the Current Behavior?

Prices are fetched whenever the LoadProductSuccess action is encountered. This happens also if the actual price is not being displayed.

What Is the New Behavior?

  • only fetch prices that are displayed (via context displayProperties)
  • introduced two update strategies:
    • stable: fetch prices only once per application lifetime
    • always: re-fetch prices every time they are displayed
  • when going to Product detail pages, the prices are updated if the product data is also updated (when completeness level true is chosen in SelectedProductContextFacade)

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

AB#76401

@dhhyi dhhyi added enhancement Enhancement to an existing feature community Community contributions labels Mar 29, 2022
@dhhyi dhhyi self-assigned this Mar 29, 2022
@dhhyi dhhyi added the wait Waiting for something (e.g. new ICM release) label Mar 29, 2022
@dhhyi dhhyi force-pushed the feat/price-update-strategies branch from e2fff4b to a65dd7c Compare March 29, 2022 11:41
@dhhyi dhhyi requested a review from Eisie96 March 29, 2022 12:40
@dhhyi dhhyi marked this pull request as ready for review March 29, 2022 12:40
@dhhyi
Copy link
Collaborator Author

dhhyi commented Mar 29, 2022

wait for integration of #1088

@dhhyi dhhyi removed their assignment Mar 29, 2022
Base automatically changed from refactor/disconnect-pricing-from-product-view to develop March 30, 2022 07:27
@dhhyi dhhyi removed the wait Waiting for something (e.g. new ICM release) label Mar 30, 2022
@dhhyi dhhyi force-pushed the feat/price-update-strategies branch from a65dd7c to 34a1be2 Compare March 30, 2022 13:46
@Eisie96 Eisie96 merged commit c980cbe into develop May 3, 2022
@Eisie96 Eisie96 deleted the feat/price-update-strategies branch May 3, 2022 09:28
@Eisie96 Eisie96 added this to the 2.3 milestone May 3, 2022
SGrueber pushed a commit that referenced this pull request May 19, 2022
@dhhyi @SGrueber
feat: introduce price update strategies (#1089)
54cff2b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eisie96 Eisie96 Eisie96 approved these changes

Assignees

@Eisie96 Eisie96

Labels
community Community contributions enhancement Enhancement to an existing feature
Projects
None yet
Milestone
2.3
Development

Successfully merging this pull request may close these issues.
2 participants
@dhhyi @Eisie96