Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fail on console error #1043

Merged
merged 1 commit into from
Mar 5, 2022
Merged

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Mar 4, 2022

PR Type

[x] Build-related changes

What Is the Current Behavior?

It looks like template errors are no longer reported as Errors since the last upgrade and so they don't fail the test anymore.

What Is the New Behavior?

Fail on every test error message.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

AB#74936

@dhhyi dhhyi added the bug Something isn't working label Mar 4, 2022
@dhhyi dhhyi added this to the 2.1 milestone Mar 4, 2022
@shauke shauke merged commit 6a3c3f2 into develop Mar 5, 2022
@shauke shauke deleted the chore/fail-test-on-console-error branch March 5, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants