Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schematics with '--dry-run' option result in error #1221

Closed
shauke opened this issue Jul 20, 2022 · 0 comments · Fixed by #1226
Closed

schematics with '--dry-run' option result in error #1221

shauke opened this issue Jul 20, 2022 · 0 comments · Fixed by #1226
Assignees
@suschneider
Labels
bug Something isn't working
Milestone
3.0

Comments

@shauke
Copy link
Collaborator

shauke commented Jul 20, 2022 •
edited by azure-boards bot
Loading

Actual Behavior

Running intershop schematics with the --dry-run option results in errors because of the appended prettier check that fails for non existing files.

Running the same schematic without --dry-runworks as expected.

Expected Behavior

Prevent the additional formatting checks with prettier for dry runs so no errors occur.

Steps to Reproduce the Bug

Run e.g.

ng g component src/app/shared/my-component  --dry-run

Note: This happens for other types than components as well.

Environment Details

Intershop PWA 2.x

Additional Context, like Screenshots, Log File Snippets etc.

image

AB#78333
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@suschneider suschneider

Labels
bug Something isn't working
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

fix: prevent linting for running schematics with dry-run option intershop/intershop-pwa
2 participants
@shauke @suschneider