Skip to content

Commit

Permalink
small visual review fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
shauke committed Dec 16, 2020
1 parent 9ddf65b commit beb81c7
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@
<dt class="col-7">{{ 'account.budget.type.' + budget.budgetPeriod + '.label' | translate }}</dt>
<dd class="col-5 column-price font-weight-bold text-right">{{ budget.budget | ishPrice }}</dd>
</dl>
<dl class="row dl-horizontal dl-separator">
<dt class="col-7">{{ 'account.budget.already_spent.label' | translate }}</dt>
<dd class="col-5 column-price font-weight-bold text-right">{{ usedBudget | ishPrice }}</dd>
</dl>
<div [ngbPopover]="BudgetPopover" placement="top" data-testing-id="user-budget-popover">
<div class="progress" [ngClass]="progressBarClass">
<div
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,10 @@ describe('User Budget Component', () => {
<dt class="col-7">account.budget.type.monthly.label</dt>
<dd class="col-5 column-price font-weight-bold text-right">USD 5000</dd>
</dl>
<dl class="row dl-horizontal dl-separator">
<dt class="col-7">account.budget.already_spent.label</dt>
<dd class="col-5 column-price font-weight-bold text-right">USD 2500</dd>
</dl>
<div data-testing-id="user-budget-popover" placement="top" ng-reflect-placement="top">
<div class="progress">
<div class="progress-bar" role="progressbar" style="width: 50%">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,9 @@
</dl>
<dl *ngIf="requisition.userBudget?.spentBudget" class="row dl-horizontal dl-separator">
<dt class="col-6">{{ 'account.budget.already_spent.label' | translate }}</dt>
<dd class="col-6">{{ requisition.userBudget.spentBudget | ishPrice }} ({{ spentPercentage | percent }})</dd>
<dd class="col-6" [ngClass]="{ 'text-danger': spentPercentage > 1 }">
{{ requisition.userBudget.spentBudget | ishPrice }} ({{ spentPercentage | percent }})
</dd>
</dl>
<dl
*ngIf="requisition.approval.statusCode !== 'APPROVED'; else leftBudgetDisplay"
Expand Down

1 comment on commit beb81c7

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Azure Demo Servers are available:

Please sign in to comment.