chore: hard tslint rules in pipeline

.github/workflows/test.yml

@@ -50,6 +50,10 @@ jobs:
           (cd schematics && npm run build && bash ../scripts/ci-test-no-changes.sh 'you probably committed unformatted code')
           (cd tslint-rules && npm run build && bash ../scripts/ci-test-no-changes.sh 'you probably committed unformatted code')
 
+      - name: Escalate TSLint Rules
+        run: |
+          node scripts/tslint-hard
+
       - name: Lint by action
         uses: mooyoul/tslint-actions@v1.1.1
         with:
@@ -127,7 +131,8 @@ jobs:
       - name: Test Schematics
         run: |
           bash e2e/test-schematics.sh
-          sh scripts/ci-check-no-additional-warnings.sh
+          node scripts/tslint-hard
+          npm run lint
 
   Cypress:
     needs: Build

.gitlab-ci.yml

@@ -717,7 +717,8 @@ schematics:
   script:
     - npm install
     - bash e2e/test-schematics.sh
-    - sh scripts/ci-check-no-additional-warnings.sh
+    - node scripts/tslint-hard
+    - npm run lint
     - echo "schematics complete"
 
 .universal_template: &universal_definition
@@ -831,7 +832,8 @@ check_tslint_no_warnings:
     - performance
   script:
     - npm ci
-    - sh scripts/ci-check-no-additional-warnings.sh
+    - node scripts/tslint-hard
+    - npm run lint
     - echo "check complete"
 
 housekeeping_images:

e2e/test-schematics.sh

@@ -81,11 +81,6 @@ npx ng g customized-copy shell/footer/footer
 stat src/app/shell/footer/custom-footer/custom-footer.component.ts
 grep 'custom-footer' src/app/app.component.html
 
-
-git add -A
-npx lint-staged
-npx tsc --project tsconfig.spec.json
-
 sed -i -e "s%icmBaseURL.*%icmBaseURL: 'http://localhost:4200',%g" src/environments/environment.prod.ts
 
 if grep mockServerAPI src/environments/environment.prod.ts
@@ -95,6 +90,10 @@ else
   sed -i -e 's/^};$/mockServerAPI: true };/' src/environments/environment.prod.ts
 fi
 
+git add -A
+npx lint-staged
+npx tsc --project tsconfig.spec.json
+
 npm run build
 
 nohup bash -c "npm run serve &"

scripts/tslint-hard.js

@@ -0,0 +1,20 @@
+const fs = require('fs');
+const { parse, stringify } = require('comment-json');
+const { execSync } = require('child_process');
+
+const tslintJson = parse(fs.readFileSync('./tslint.json', { encoding: 'UTF-8' }));
+
+Object.keys(tslintJson.rules)
+  .filter(key => key !== 'no-disabled-tests')
+  .forEach(key => {
+    if (
+      typeof tslintJson.rules[key] === 'object' &&
+      tslintJson.rules[key].severity &&
+      tslintJson.rules[key].severity.startsWith('warn')
+    ) {
+      tslintJson.rules[key].severity = 'error';
+    }
+  });
+
+fs.writeFileSync('./tslint.json', stringify(tslintJson, null, 2));
+execSync('npx prettier --write tslint.json');