Skip to content

Commit

Permalink
change powerlift default python implementation to 3.12
Browse files Browse the repository at this point in the history
  • Loading branch information
paulbkoch committed Dec 18, 2024
1 parent a054d02 commit 5f12623
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 8 deletions.
6 changes: 3 additions & 3 deletions python/powerlift/powerlift/executors/azure_ci.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ def __init__(
mem_size_gb: int = 16,
# other images available at:
# https://mcr.microsoft.com/en-us/product/devcontainers/python/tags
# TODO: change default to mcr.microsoft.com/devcontainers/python:latest
image: str = "mcr.microsoft.com/devcontainers/python:latest",
# alternative: "mcr.microsoft.com/devcontainers/python:latest"
image: str = "mcr.microsoft.com/devcontainers/python:3.12",
docker_db_uri: Optional[str] = None,
resource_uris: Optional[List[str]] = None,
max_undead: int = 20,
Expand All @@ -55,7 +55,7 @@ def __init__(
n_instances (int, optional): Max number of containers to run simultaneously. Defaults to 1.
num_cores (int, optional): Number of cores per container. Defaults to 1.
mem_size_gb (int, optional): RAM size in GB per container. Defaults to 2.
image (str, optional): Image to execute. Defaults to "mcr.microsoft.com/devcontainers/python:latest".
image (str, optional): Image to execute. Defaults to "mcr.microsoft.com/devcontainers/python:3.12".
docker_db_uri (str, optional): Database URI for container. Defaults to None.
resource_uris (List[str], optional): Azure resources to grant contributor access permissions to.
max_undead (int): maximum number of containers that are allowed to be left alive if there is an error during initialization. Higher numbers increase the speed of initialization, but might incur higher cost if any zombies escape.
Expand Down
6 changes: 3 additions & 3 deletions python/powerlift/powerlift/executors/bicep_azure_ci.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ def __init__(
mem_size_gb: int = 16,
# other images available at:
# https://mcr.microsoft.com/en-us/product/devcontainers/python/tags
# TODO: change default to mcr.microsoft.com/devcontainers/python:latest
image: str = "mcr.microsoft.com/devcontainers/python:latest",
# alternative: "mcr.microsoft.com/devcontainers/python:latest"
image: str = "mcr.microsoft.com/devcontainers/python:3.12",
docker_db_uri: Optional[str] = None,
resource_uris: Optional[List[str]] = None,
delete_on_complete: bool = True,
Expand All @@ -55,7 +55,7 @@ def __init__(
n_instances (int, optional): Max number of containers to run simultaneously. Defaults to 1.
num_cores (int, optional): Number of cores per container. Defaults to 1.
mem_size_gb (int, optional): RAM size in GB per container. Defaults to 2.
image (str, optional): Image to execute. Defaults to "mcr.microsoft.com/devcontainers/python:latest".
image (str, optional): Image to execute. Defaults to "mcr.microsoft.com/devcontainers/python:3.12".
docker_db_uri (str, optional): Database URI for container. Defaults to None.
resource_uris (List[str], optional): Azure resources to grant contributor access permissions to.
delete_on_complete (bool, optional): Delete group containers after completion. Defaults to True.
Expand Down
5 changes: 3 additions & 2 deletions python/powerlift/powerlift/executors/docker.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@ class InsecureDocker(LocalMachine):
def __init__(
self,
store: Store,
image: str = "mcr.microsoft.com/devcontainers/python:latest",
# alternative: "mcr.microsoft.com/devcontainers/python:latest"
image: str = "mcr.microsoft.com/devcontainers/python:3.12",
n_running_containers: Optional[int] = None,
wheel_filepaths: Optional[List[str]] = None,
docker_db_uri: Optional[str] = None,
Expand All @@ -55,7 +56,7 @@ def __init__(
Args:
store (Store): Store that houses trials.
image (str, optional): Image to execute in container. Defaults to "mcr.microsoft.com/devcontainers/python:latest".
image (str, optional): Image to execute in container. Defaults to "mcr.microsoft.com/devcontainers/python:3.12".
n_running_containers (int, optional): Max number of containers running simultaneously. Defaults to None.
wheel_filepaths (List[str], optional): List of wheel filepaths to install on docker trial run. Defaults to None.
docker_db_uri (str, optional): Database URI for container. Defaults to None.
Expand Down

0 comments on commit 5f12623

Please sign in to comment.