drop python 3.6 support and fix build failures#557
Merged
Conversation
imatiach-msft
force-pushed
the
ilmat/fix-builds
branch
2 times, most recently
from
March 31, 2023 13:55
10f1e17 to
2722709
Compare
RubyZ10
approved these changes
Mar 31, 2023
imatiach-msft
force-pushed
the
ilmat/fix-builds
branch
3 times, most recently
from
March 31, 2023 16:24
4b2ddc2 to
da3d821
Compare
Codecov ReportPatch coverage has no change and project coverage change:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #557 +/- ##
==========================================
- Coverage 87.83% 87.66% -0.18%
==========================================
Files 62 62
Lines 4094 4094
==========================================
- Hits 3596 3589 -7
- Misses 498 505 +7
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The interpret-community gated builds started failing recently with the pytorch 2.0.0 update. Trying to get packages working on python 3.6 has become quite difficult recently and involves a lot of pinning due to so many other OSS packages dropping python 3.6 support. Hence, this PR tries to:
1.) Drop python 3.6 support. Now we will primarily test on python 3.7, 3.8 and 3.9
2.) Fix the build failures currently occurring on main