Skip to content

fix nightly pytorch error on macos by installing numpy from conda#535

Merged
imatiach-msft merged 1 commit into
interpretml:mainfrom
imatiach-msft:ilmat/fix-nightly-err
Jul 19, 2022
Merged

fix nightly pytorch error on macos by installing numpy from conda#535
imatiach-msft merged 1 commit into
interpretml:mainfrom
imatiach-msft:ilmat/fix-nightly-err

Conversation

@imatiach-msft

@imatiach-msft imatiach-msft commented Jul 18, 2022

Copy link
Copy Markdown
Collaborator

rely on installing numpy from conda - otherwise we see segfaults on macos when installing pytorch and lightgbm together:

/Users/runner/work/_temp/166c9a15-3b69-4e3f-a25e-1b51a6c0154c.sh: line 2: 13956 Segmentation fault: 11  python -m pytest tests/ -m "not notebooks" --junitxml=./TEST--TEST.xml -o junit_suite_name="MacOS Unit 3.7-Unit"

Update - see passing nightly build here:
https://dev.azure.com/responsibleai/interpret-community/_build/results?buildId=14736&view=results

@codecov-commenter

codecov-commenter commented Jul 18, 2022

Copy link
Copy Markdown

Codecov Report

Merging #535 (0232244) into main (4970f08) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #535   +/-   ##
=======================================
  Coverage   87.63%   87.63%           
=======================================
  Files          62       62           
  Lines        4077     4077           
=======================================
  Hits         3573     3573           
  Misses        504      504           
Flag Coverage Δ
unittests 87.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a15b3e...0232244. Read the comment docs.

@imatiach-msft
imatiach-msft force-pushed the ilmat/fix-nightly-err branch 5 times, most recently from 8ed6d61 to 0232244 Compare July 19, 2022 14:24
@imatiach-msft imatiach-msft changed the title fix nightly pytorch error on macos by installing lightgbm via pypi fix nightly pytorch error on macos by installing numpy from conda Jul 19, 2022
@imatiach-msft
imatiach-msft force-pushed the ilmat/fix-nightly-err branch from 0232244 to cf3ea8b Compare July 19, 2022 16:57
@imatiach-msft
imatiach-msft merged commit 327719c into interpretml:main Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants