Fix to unify type comparison methods

[daikikatsuragawa]

This is a modification to unify the type comparison method.

Previously, there were two methods

• if type(ABC) is str:
• if isinstance(ABC, str):

This fix is related to coding and does not affect services. However, this unification is expected to increase code maintainability during development.

Use isinstance() rather than type() for a typecheck.
reference : https://pycodequ.al/docs/pylint-messages/c0123-unidiomatic-typecheck.html

[gaugup]

@daikikatsuragawa Thanks for the PR. Could you add a flake8 rule to test for the above as per https://www.flake8rules.com/rules/E721.html? It will be useful for future that we don't add class checks with type. What do you think?

[daikikatsuragawa]

@gaugup

Could you add a flake8 rule to test for the above as per https://www.flake8rules.com/rules/E721.html? It will be useful for future that we don't add class checks with type. What do you think?

Thank you. I will add it. Also, I will fix the failing CI.

[daikikatsuragawa]

I will fix the failing CI.

This one has been corrected.
bb43f48

[daikikatsuragawa]

@gaugup

Could you add a flake8 rule to test for the above as per https://www.flake8rules.com/rules/E721.html? It will be useful for future that we don't add class checks with type. What do you think?

I was considering adding the following.

DiCE/.github/workflows/python-linting.yml

Line 32 in ea6f484

flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics

I tried the following locally, added the error code, and verified that it did not seem to be working properly.

$ flake8 . --count --select=E721,E9,F63,F7,F82 --show-source --statistics

What is it, do you know? 🤔

[amit-sharma]

I tried the following locally, added the error code, and verified that it did not seem to be working properly.

$ flake8 . --count --select=E721,E9,F63,F7,F82 --show-source --statistics

What is it, do you know? 🤔

Ah, do you mean that the flake8 still passes when type is used in the code?

[daikikatsuragawa]

Yes, that's right.